content/child/service_worker/web_service_worker_registration_impl.h - Issue 2489883006: Replace registration_id() with registrationId()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.h

Issue 2489883006: Replace registration_id() with registrationId() (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_dispatcher_unittest.cc ('k') | content/child/service_worker/web_service_worker_registration_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_registration_impl.h

diff --git a/content/child/service_worker/web_service_worker_registration_impl.h b/content/child/service_worker/web_service_worker_registration_impl.h

index 715345c12d6b7fe956d7aca1f886d953f5f62b56..ce30fb00eae8dec1cf096f951825d3d01fa9f00f 100644

--- a/content/child/service_worker/web_service_worker_registration_impl.h

+++ b/content/child/service_worker/web_service_worker_registration_impl.h

@@ -68,9 +68,6 @@ class CONTENT_EXPORT WebServiceWorkerRegistrationImpl

override;

int64_t registrationId() const override;

- // TODO(adithyas): Remove this function and use registrationId() instead

- int64_t registration_id() const;

using WebServiceWorkerRegistrationHandle =

blink::WebServiceWorkerRegistration::Handle;