Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: content/child/service_worker/web_service_worker_registration_impl.h

Issue 2489883006: Replace registration_id() with registrationId() (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_REGISTRATION_IMPL_H_ 5 #ifndef CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_REGISTRATION_IMPL_H_
6 #define CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_REGISTRATION_IMPL_H_ 6 #define CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_REGISTRATION_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 blink::WebServiceWorkerProvider* provider, 61 blink::WebServiceWorkerProvider* provider,
62 std::unique_ptr<WebGetNavigationPreloadStateCallbacks> callbacks) 62 std::unique_ptr<WebGetNavigationPreloadStateCallbacks> callbacks)
63 override; 63 override;
64 void setNavigationPreloadHeader( 64 void setNavigationPreloadHeader(
65 const blink::WebString& value, 65 const blink::WebString& value,
66 blink::WebServiceWorkerProvider* provider, 66 blink::WebServiceWorkerProvider* provider,
67 std::unique_ptr<WebSetNavigationPreloadHeaderCallbacks> callbacks) 67 std::unique_ptr<WebSetNavigationPreloadHeaderCallbacks> callbacks)
68 override; 68 override;
69 int64_t registrationId() const override; 69 int64_t registrationId() const override;
70 70
71 // TODO(adithyas): Remove this function and use registrationId() instead
72 int64_t registration_id() const;
73
74 using WebServiceWorkerRegistrationHandle = 71 using WebServiceWorkerRegistrationHandle =
75 blink::WebServiceWorkerRegistration::Handle; 72 blink::WebServiceWorkerRegistration::Handle;
76 73
77 // Creates WebServiceWorkerRegistrationHandle object that owns a reference to 74 // Creates WebServiceWorkerRegistrationHandle object that owns a reference to
78 // the given WebServiceWorkerRegistrationImpl object. 75 // the given WebServiceWorkerRegistrationImpl object.
79 static std::unique_ptr<WebServiceWorkerRegistrationHandle> CreateHandle( 76 static std::unique_ptr<WebServiceWorkerRegistrationHandle> CreateHandle(
80 const scoped_refptr<WebServiceWorkerRegistrationImpl>& registration); 77 const scoped_refptr<WebServiceWorkerRegistrationImpl>& registration);
81 78
82 // Same with CreateHandle(), but returns a raw pointer to the handle w/ its 79 // Same with CreateHandle(), but returns a raw pointer to the handle w/ its
83 // ownership instead. The caller must manage the ownership. This function must 80 // ownership instead. The caller must manage the ownership. This function must
(...skipping 28 matching lines...) Expand all
112 blink::WebServiceWorkerRegistrationProxy* proxy_; 109 blink::WebServiceWorkerRegistrationProxy* proxy_;
113 110
114 std::vector<QueuedTask> queued_tasks_; 111 std::vector<QueuedTask> queued_tasks_;
115 112
116 DISALLOW_COPY_AND_ASSIGN(WebServiceWorkerRegistrationImpl); 113 DISALLOW_COPY_AND_ASSIGN(WebServiceWorkerRegistrationImpl);
117 }; 114 };
118 115
119 } // namespace content 116 } // namespace content
120 117
121 #endif // CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_REGISTRATION_IMPL_H_ 118 #endif // CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_REGISTRATION_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698