bluetooth: Componentize device list fixes

bluetooth: Componentize device list fixes

Fixes for componentization of device list introduced in issue:
https://codereview.chromium.org/2446823002/

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d16c52cc047907ba252ef8ea0d09dcec78e1a377
Cr-Commit-Position: refs/heads/master@{#431681}

[mbrunson, 2016-11-10 00:59:24]

Description was changed from

==========
bluetooth: Componentize device list fixes

Fixes for componentization of device list introduced in issue:
https://codereview.chromium.org/2446823002/

BUG=651282
==========

to

==========
bluetooth: Componentize device list fixes

Fixes for componentization of device list introduced in issue:
https://codereview.chromium.org/2446823002/

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mbrunson, 2016-11-10 01:03:09]

mbrunson@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-11-10 03:22:59]

https://codereview.chromium.org/2488093003/diff/1/chrome/browser/resources/bl...
File chrome/browser/resources/bluetooth_internals/device_table.js (right):

https://codereview.chromium.org/2488093003/diff/1/chrome/browser/resources/bl...
chrome/browser/resources/bluetooth_internals/device_table.js:10: var
REMOVED_CLASS_NAME = 'removed';
why do you need this constant now?  can you just inline 'removed' later on in
this file?

https://codereview.chromium.org/2488093003/diff/1/chrome/browser/resources/bl...
chrome/browser/resources/bluetooth_internals/device_table.js:19: // @type
{?Array<device_collection.Device>}
// comments aren't jsdoc

you need

/** These type of comments. */

[mbrunson, 2016-11-10 04:06:03]

https://codereview.chromium.org/2488093003/diff/1/chrome/browser/resources/bl...
File chrome/browser/resources/bluetooth_internals/device_table.js (right):

https://codereview.chromium.org/2488093003/diff/1/chrome/browser/resources/bl...
chrome/browser/resources/bluetooth_internals/device_table.js:10: var
REMOVED_CLASS_NAME = 'removed';
On 2016/11/10 03:22:59, Dan Beam wrote:
> why do you need this constant now?  can you just inline 'removed' later on in
> this file?

Ah, yes. Since it's only used in one place now, I can remove this. Done.

https://codereview.chromium.org/2488093003/diff/1/chrome/browser/resources/bl...
chrome/browser/resources/bluetooth_internals/device_table.js:19: // @type
{?Array<device_collection.Device>}
On 2016/11/10 03:22:59, Dan Beam wrote:
> // comments aren't jsdoc
> 
> you need
> 
> /** These type of comments. */

Ah ok. Done.

[Dan Beam, 2016-11-11 06:32:31]

lgtm

https://codereview.chromium.org/2488093003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/bluetooth_internals/device_table.js (right):

https://codereview.chromium.org/2488093003/diff/40001/chrome/browser/resource...
chrome/browser/resources/bluetooth_internals/device_table.js:18: *  @private
nit: you can combine this into

/** @private {?Array<device_collection.Device>} */

[mbrunson, 2016-11-11 20:43:09]

https://codereview.chromium.org/2488093003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/bluetooth_internals/device_table.js (right):

https://codereview.chromium.org/2488093003/diff/40001/chrome/browser/resource...
chrome/browser/resources/bluetooth_internals/device_table.js:18: *  @private
On 2016/11/11 06:32:31, Dan Beam wrote:
> nit: you can combine this into
> 
> /** @private {?Array<device_collection.Device>} */

Done.

[mbrunson, 2016-11-11 20:45:04]

The CQ bit was checked by mbrunson@chromium.org

[mbrunson, 2016-11-11 20:45:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2488093003/#ps60001
(title: "Combine private and type")

[mbrunson, 2016-11-11 20:45:09]

The CQ bit was unchecked by mbrunson@chromium.org

[mbrunson, 2016-11-11 20:45:13]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 20:45:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 23:01:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 23:01:02]

Dry run: This issue passed the CQ dry run.

[mbrunson, 2016-11-11 23:10:41]

The CQ bit was checked by mbrunson@chromium.org

[commit-bot: I haz the power, 2016-11-11 23:11:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 23:17:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-11 23:54:27]

Description was changed from

==========
bluetooth: Componentize device list fixes

Fixes for componentization of device list introduced in issue:
https://codereview.chromium.org/2446823002/

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Componentize device list fixes

Fixes for componentization of device list introduced in issue:
https://codereview.chromium.org/2446823002/

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d16c52cc047907ba252ef8ea0d09dcec78e1a377
Cr-Commit-Position: refs/heads/master@{#431681}
==========

[commit-bot: I haz the power, 2016-11-11 23:54:28]

Patchset 4 (id:??) landed as
https://crrev.com/d16c52cc047907ba252ef8ea0d09dcec78e1a377
Cr-Commit-Position: refs/heads/master@{#431681}