Remove delayed error posting from AndroidVideoDecodeAccelerator

Remove delayed error posting from AndroidVideoDecodeAccelerator

Now that we're always notifying AVDA when it loses its output surface
there's no need to delay errors. Errors are always "real" errors now.

BUG=662599
TEST=entering and exiting fullscreen still works
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f1243d90b59f3361db000970862413cc12ddb6fa
Cr-Commit-Position: refs/heads/master@{#431678}

[watk, 2016-11-08 22:09:42]

Description was changed from

==========
Remove delayed error posting from AndroidVideoDecodeAccelerator

Now that we're always notifying AVDA when it loses its output surface
there's no need to delay errors. Errors are always "real" errors now.

BUG=662599
==========

to

==========
Remove delayed error posting from AndroidVideoDecodeAccelerator

Now that we're always notifying AVDA when it loses its output surface
there's no need to delay errors. Errors are always "real" errors now.

BUG=662599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[watk, 2016-11-08 22:09:59]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 22:10:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[watk, 2016-11-08 22:12:12]

watk@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[watk, 2016-11-08 22:12:55]

Description was changed from

==========
Remove delayed error posting from AndroidVideoDecodeAccelerator

Now that we're always notifying AVDA when it loses its output surface
there's no need to delay errors. Errors are always "real" errors now.

BUG=662599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove delayed error posting from AndroidVideoDecodeAccelerator

Now that we're always notifying AVDA when it loses its output surface
there's no need to delay errors. Errors are always "real" errors now.

BUG=662599
TEST=entering and exiting fullscreen still works
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[DaleCurtis, 2016-11-08 22:14:36]

Hmm, isn't this not true until you add code to wait for destruction to actually
complete?

[watk, 2016-11-08 22:19:53]

We go into state_ == SURFACE_DESTROYED which is supposed to be terminal and set
media_codec_ to nullptr. So there shouldn't be any way to get an error that
might have to be deferred.

[commit-bot: I haz the power, 2016-11-08 22:34:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 22:34:33]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[watk, 2016-11-08 23:42:00]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 23:43:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 00:53:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 00:53:39]

Dry run: This issue passed the CQ dry run.

[DaleCurtis, 2016-11-10 01:51:32]

Whoops, didn't mean to wait to lgtm this until after my change. Sorry! Hope it
merges cleanly!

[watk, 2016-11-10 01:57:40]

On 2016/11/10 01:51:32, DaleCurtis wrote:
> Whoops, didn't mean to wait to lgtm this until after my change. Sorry! Hope it
> merges cleanly!

That's very convenient timing ¬_¬. haha, no worries.

[watk, 2016-11-10 23:54:51]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 23:55:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[watk, 2016-11-10 23:56:14]

The CQ bit was unchecked by watk@chromium.org

[watk, 2016-11-10 23:56:15]

The CQ bit was checked by watk@chromium.org

[watk, 2016-11-10 23:56:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2487813002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-10 23:56:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 00:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 00:06:48]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[watk, 2016-11-11 01:26:14]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2016-11-11 01:26:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 01:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 01:46:23]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[watk, 2016-11-11 20:05:07]

The CQ bit was checked by watk@chromium.org

[watk, 2016-11-11 20:05:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2487813002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-11 20:05:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 23:12:40]

Description was changed from

==========
Remove delayed error posting from AndroidVideoDecodeAccelerator

Now that we're always notifying AVDA when it loses its output surface
there's no need to delay errors. Errors are always "real" errors now.

BUG=662599
TEST=entering and exiting fullscreen still works
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove delayed error posting from AndroidVideoDecodeAccelerator

Now that we're always notifying AVDA when it loses its output surface
there's no need to delay errors. Errors are always "real" errors now.

BUG=662599
TEST=entering and exiting fullscreen still works
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-11 23:12:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-11 23:54:20]

Description was changed from

==========
Remove delayed error posting from AndroidVideoDecodeAccelerator

Now that we're always notifying AVDA when it loses its output surface
there's no need to delay errors. Errors are always "real" errors now.

BUG=662599
TEST=entering and exiting fullscreen still works
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove delayed error posting from AndroidVideoDecodeAccelerator

Now that we're always notifying AVDA when it loses its output surface
there's no need to delay errors. Errors are always "real" errors now.

BUG=662599
TEST=entering and exiting fullscreen still works
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/f1243d90b59f3361db000970862413cc12ddb6fa
Cr-Commit-Position: refs/heads/master@{#431678}
==========

[commit-bot: I haz the power, 2016-11-11 23:54:23]

Patchset 4 (id:??) landed as
https://crrev.com/f1243d90b59f3361db000970862413cc12ddb6fa
Cr-Commit-Position: refs/heads/master@{#431678}