Remove delayed error posting from AndroidVideoDecodeAccelerator

media/gpu/avda_picture_buffer_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/gpu/avda_picture_buffer_manager.h"
 
 #include <EGL/egl.h>
 #include <EGL/eglext.h>
 
 #include "base/android/build_info.h"
@@ skipping 10 matching lines @@
 #include "media/base/android/sdk_media_codec_bridge.h"
 #include "media/gpu/avda_codec_image.h"
 #include "media/gpu/avda_shared_state.h"
 #include "ui/gl/android/surface_texture.h"
 #include "ui/gl/egl_util.h"
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_surface_egl.h"
 #include "ui/gl/scoped_binders.h"
 #include "ui/gl/scoped_make_current.h"
 
-// If !|ptr|, log a message, post an error to |state_provider_|, and
+// If !|ptr|, log a message, notify |state_provider_| of the error, and
 // return an optional value.
-#define RETURN_IF_NULL(ptr, ...)                                         \
-  do {                                                                   \
-    if (!(ptr)) {                                                        \
-      DLOG(ERROR) << "Got null for " << #ptr;                            \
-      state_provider_->PostError(FROM_HERE,                              \
-                                 VideoDecodeAccelerator::ILLEGAL_STATE); \
-      return __VA_ARGS__;                                                \
-    }                                                                    \
+#define RETURN_IF_NULL(ptr, ...)                                           \
+  do {                                                                     \
+    if (!(ptr)) {                                                          \
+      DLOG(ERROR) << "Got null for " << #ptr;                              \
+      state_provider_->NotifyError(VideoDecodeAccelerator::ILLEGAL_STATE); \
+      return __VA_ARGS__;                                                  \
+    }                                                                      \
   } while (0)
 
 namespace media {
 namespace {
 
 // Creates a SurfaceTexture and attaches a new gl texture to it. |*service_id|
 // is set to the new texture id.
 scoped_refptr<gl::SurfaceTexture> CreateAttachedSurfaceTexture(
     base::WeakPtr<gpu::gles2::GLES2Decoder> gl_decoder,
     GLuint* service_id) {
@@ skipping 242 matching lines @@
 
 bool AVDAPictureBufferManager::HasUnrenderedPictures() const {
   for (int id : pictures_out_for_display_) {
     if (GetImageForPicture(id)->is_unrendered())
       return true;
   }
   return false;
 }
 
 }  // namespace media