Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: media/gpu/avda_state_provider.h

Issue 2487813002: Remove delayed error posting from AndroidVideoDecodeAccelerator (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/gpu/avda_picture_buffer_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/avda_state_provider.h
diff --git a/media/gpu/avda_state_provider.h b/media/gpu/avda_state_provider.h
index 06498f7d77a150b621198f9e07aab861a54b4e65..819992d43f7953655a3d2075cb519338645621ad 100644
--- a/media/gpu/avda_state_provider.h
+++ b/media/gpu/avda_state_provider.h
@@ -26,11 +26,9 @@ class AVDAStateProvider {
virtual const gfx::Size& GetSize() const = 0;
virtual base::WeakPtr<gpu::gles2::GLES2Decoder> GetGlDecoder() const = 0;
- // Helper function to report an error condition and stop decoding.
- // This will post NotifyError(), and transition to the error state.
- // It is meant to be called from the RETURN_ON_FAILURE macro.
- virtual void PostError(const ::tracked_objects::Location& from_here,
- VideoDecodeAccelerator::Error error) = 0;
+ // Report a fatal error. This will post NotifyError(), and transition to the
+ // error state.
+ virtual void NotifyError(VideoDecodeAccelerator::Error error) = 0;
protected:
~AVDAStateProvider() = default;
« no previous file with comments | « media/gpu/avda_picture_buffer_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698