Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2487763003: [ImageLoader 2d] Set DecodeError by calling ResourceLoader::cancel()

Created:
4 years, 1 month ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set DecodeError by calling ResourceLoader::cancel() BUG= TESTS=http/tests/inspector/network/network-image-404.html http/tests/inspector/resource-tree/resource-tree-non-unique-url.html

Patch Set 1 #

Patch Set 2 : fix2 #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -39 lines) Patch
M third_party/WebKit/Source/core/fetch/FetchContext.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 1 2 chunks +15 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 2 4 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.cpp View 1 2 3 4 chunks +16 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScannerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 1 chunk +12 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 2486143002 Patch 20001

Dependent Patchsets:

Issue 2485873004 Patch 60001

Messages

Total messages: 16 (16 generated)
hiroshige
Description was changed from ========== Set DecodeError by calling ResourceLoader::cancel() BUG= ========== to ========== Set ...
4 years, 1 month ago (2016-11-09 07:19:55 UTC) #1
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-09 07:20:57 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487763003/1
4 years, 1 month ago (2016-11-09 07:21:10 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-09 08:31:50 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/331808)
4 years, 1 month ago (2016-11-09 08:31:51 UTC) #5
hiroshige
Description was changed from ========== Set DecodeError by calling ResourceLoader::cancel() BUG= ========== to ========== Set ...
4 years, 1 month ago (2016-11-09 11:11:19 UTC) #6
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-09 11:12:52 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487763003/20001
4 years, 1 month ago (2016-11-09 11:13:00 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-09 11:15:31 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/331846)
4 years, 1 month ago (2016-11-09 11:15:32 UTC) #10
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-09 11:42:00 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487763003/40001
4 years, 1 month ago (2016-11-09 11:42:11 UTC) #12
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-09 11:52:35 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487763003/60001
4 years, 1 month ago (2016-11-09 11:52:41 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-09 12:18:13 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 12:18:14 UTC) #16 
Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Powered by Google App Engine
This is Rietveld 408576698