Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2486143002: Deprecated [ImageLoader 1c] Make StyleFetchedImageSet no longer ResourceClient (Closed)

Created:
4 years, 1 month ago by hiroshige
Modified:
3 years, 12 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make StyleFetchedImageSet no longer ResourceClient BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 2 chunks +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (9 generated)
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-09 07:18:05 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486143002/1
4 years, 1 month ago (2016-11-09 07:18:14 UTC) #2
hiroshige
Description was changed from ========== Make StyleFetchedImageSet no longer ResourceClient BUG= ========== to ========== Make ...
4 years, 1 month ago (2016-11-09 07:20:05 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-09 09:19:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 1 month ago (2016-11-09 09:19:07 UTC) #5
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-09 11:38:59 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486143002/20001
4 years, 1 month ago (2016-11-09 11:39:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-09 13:22:45 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 13:22:48 UTC) #9
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698