Convert InfoBarTestAnimationListener to CallbackHelper.

Convert InfoBarTestAnimationListener to CallbackHelper.

In addition, this adds the ability to log a better error message
in CallbackHelper when the timeout fails.

BUG=656815
Committed: https://crrev.com/7209a6e51b6a4afc887ba9a02e2a211cc0011b80
Cr-Commit-Position: refs/heads/master@{#430686}

[Ted C, 2016-11-08 18:38:14]

tedchoc@chromium.org changed reviewers:
+ dfalcantara@chromium.org, jbudorick@chromium.org

[Ted C, 2016-11-08 18:38:14]

PTAL

jbudorick base/test/*
dfalcantara chrome/*

[jbudorick, 2016-11-08 18:41:44]

base/test/android/ lgtm

https://codereview.chromium.org/2487683003/diff/1/base/test/android/javatests...
File
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java
(right):

https://codereview.chromium.org/2487683003/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java:200:
public void waitForCallback(int currentCallCount, int numberOfCallsToWaitFor)
I guess we'll add waitForCallback(String, int, int) when we need it?

[Ted C, 2016-11-08 18:47:10]

On 2016/11/08 18:41:44, jbudorick wrote:
> base/test/android/ lgtm
> 
>
https://codereview.chromium.org/2487683003/diff/1/base/test/android/javatests...
> File
>
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java
> (right):
> 
>
https://codereview.chromium.org/2487683003/diff/1/base/test/android/javatests...
>
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java:200:
> public void waitForCallback(int currentCallCount, int numberOfCallsToWaitFor)
> I guess we'll add waitForCallback(String, int, int) when we need it?

Yeah, that was my thought.  I had a glimmer of hope that I could remove
some of the other existing methods, but they are all used :-/

[jbudorick, 2016-11-08 18:48:58]

On 2016/11/08 18:47:10, Ted C wrote:
> On 2016/11/08 18:41:44, jbudorick wrote:
> > base/test/android/ lgtm
> > 
> >
>
https://codereview.chromium.org/2487683003/diff/1/base/test/android/javatests...
> > File
> >
>
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/2487683003/diff/1/base/test/android/javatests...
> >
>
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java:200:
> > public void waitForCallback(int currentCallCount, int
numberOfCallsToWaitFor)
> > I guess we'll add waitForCallback(String, int, int) when we need it?
> 
> Yeah, that was my thought.  I had a glimmer of hope that I could remove
> some of the other existing methods, but they are all used :-/

sgtm. Yoland just moved this into base/test/android a few weeks ago, so I'm not
surprised that everything's in use. It'd be good to work toward having more
descriptive messages in all uses of the CallbackHelper, though -- maybe an item
for the next PE fixit.

[gone, 2016-11-08 19:01:26]

lgtm

[Ted C, 2016-11-08 19:01:55]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2016-11-08 19:02:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 19:43:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-08 20:10:39]

Description was changed from

==========
Convert InfoBarTestAnimationListener to CallbackHelper.

In addition, this adds the ability to log a better error message
in CallbackHelper when the timeout fails.

BUG=656815
==========

to

==========
Convert InfoBarTestAnimationListener to CallbackHelper.

In addition, this adds the ability to log a better error message
in CallbackHelper when the timeout fails.

BUG=656815

Committed: https://crrev.com/7209a6e51b6a4afc887ba9a02e2a211cc0011b80
Cr-Commit-Position: refs/heads/master@{#430686}
==========

[commit-bot: I haz the power, 2016-11-08 20:10:40]

Patchset 1 (id:??) landed as
https://crrev.com/7209a6e51b6a4afc887ba9a02e2a211cc0011b80
Cr-Commit-Position: refs/heads/master@{#430686}