chrome/android/javatests/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfobarTest.java - Issue 2487683003: Convert InfoBarTestAnimationListener to CallbackHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfobarTest.java

Issue 2487683003: Convert InfoBarTestAnimationListener to CallbackHelper. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfobarTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfobarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfobarTest.java

index 1d829f33bc5cf93bbec8d9d3fb2e578c6d7824f6..75c00d50343a33b86dd963641f461b4281cbf164 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfobarTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfobarTest.java

@@ -63,7 +63,7 @@ public class PermissionUpdateInfobarTest extends ChromeTabbedActivityTestBase {

// permissions.

@MediumTest

public void testInfobarShutsDownCleanlyForGeolocation()

- throws IllegalArgumentException, InterruptedException {

+ throws IllegalArgumentException, InterruptedException, TimeoutException {

ChromeTabUtils.newTabFromMenu(getInstrumentation(), getActivity());

// Register for animation notifications

@@ -104,7 +104,7 @@ public class PermissionUpdateInfobarTest extends ChromeTabbedActivityTestBase {

});

loadUrl(mTestServer.getURL(GEOLOCATION_PAGE));

- assertTrue("InfoBar not added", mListener.addInfoBarAnimationFinished());

+ mListener.addInfoBarAnimationFinished("InfoBar not added");

assertEquals(1, getInfoBars().size());

final WebContents webContents = ThreadUtils.runOnUiThreadBlockingNoException(

@@ -183,7 +183,7 @@ public class PermissionUpdateInfobarTest extends ChromeTabbedActivityTestBase {

});

loadUrl(mTestServer.getURL(GEOLOCATION_IFRAME_PAGE));

- assertTrue("InfoBar not added", mListener.addInfoBarAnimationFinished());

+ mListener.addInfoBarAnimationFinished("InfoBar not added");

assertEquals(1, getInfoBars().size());

final WebContents webContents = ThreadUtils.runOnUiThreadBlockingNoException(