chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java - Issue 2487683003: Convert InfoBarTestAnimationListener to CallbackHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java

Issue 2487683003: Convert InfoBarTestAnimationListener to CallbackHelper. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestCaseBase.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateInfoBarTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java

index 15179112c122e9b073e22180debbe87aebddd35f..9a144f07965289adae218e13800d632e140a1996 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java

@@ -106,7 +106,7 @@ public class SiteSettingsPreferencesTest extends ChromeActivityTestCaseBase<Chro

// Launch a page that uses geolocation and make sure an infobar shows up.

loadUrl(mTestServer.getURL(

"/chrome/test/data/geolocation/geolocation_on_load.html"));

- assertTrue("InfoBar not added.", listener.addInfoBarAnimationFinished());

+ listener.addInfoBarAnimationFinished("InfoBar not added.");

assertEquals("Wrong infobar count", 1, getInfoBars().size());

}

@@ -556,7 +556,7 @@ public class SiteSettingsPreferencesTest extends ChromeActivityTestCaseBase<Chro

loadUrl(mTestServer.getURL("/content/test/data/media/getusermedia.html"));

runJavaScriptCodeInCurrentTab("getUserMediaAndStop({video: true, audio: false});");

- assertTrue("InfoBar not added.", listener.addInfoBarAnimationFinished());

+ listener.addInfoBarAnimationFinished("InfoBar not added.");

assertEquals("Wrong infobar count", 1, getInfoBars().size());

}

@@ -576,7 +576,7 @@ public class SiteSettingsPreferencesTest extends ChromeActivityTestCaseBase<Chro

loadUrl(mTestServer.getURL("/content/test/data/media/getusermedia.html"));

runJavaScriptCodeInCurrentTab("getUserMediaAndStop({video: false, audio: true});");

- assertTrue("InfoBar not added.", listener.addInfoBarAnimationFinished());

+ listener.addInfoBarAnimationFinished("InfoBar not added.");

assertEquals("Wrong infobar count", 1, getInfoBars().size());

}