android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java - Issue 2487673006: Fix bug: turns on BIND_EXTERNAL_SERVICE flag on Android N crashes WebAPK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

Issue 2487673006: Fix bug: turns on BIND_EXTERNAL_SERVICE flag on Android N crashes WebAPK. (Closed)

Patch Set: Add a TODO. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java b/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

index 9c5d8d6ff198b830457d65a59c69500bf56a32cc..7eb2c2b5bcebbe70587b1bd0a36b1b4a9335a544 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

@@ -61,9 +61,10 @@ public abstract class AwBrowserProcess {

* Configures child process launcher. This is required only if child services are used in

* WebView.

- public static void configureChildProcessLauncher(String packageName, int extraBindFlags) {

+ public static void configureChildProcessLauncher(String packageName,

+ boolean isExternalService) {

ChildProcessCreationParams.set(

- new ChildProcessCreationParams(packageName, extraBindFlags,

+ new ChildProcessCreationParams(packageName, isExternalService,

LibraryProcessType.PROCESS_WEBVIEW_CHILD));

}