Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2487673006: Fix bug: turns on BIND_EXTERNAL_SERVICE flag on Android N crashes WebAPK. (Closed)
Patch Set: Add a TODO. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
index 4129b2db7e5688da19f66595b9012ce5a5cd5032..df399e8c3c045d241d81839a51f6e2e7d2f8c843 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
@@ -159,12 +159,13 @@ public class WebApkActivity extends WebappActivity {
* WebAPK renderer process.
*/
private void initializeChildProcessCreationParams(boolean isForWebApk) {
+ // TODO(hanxi): crbug.com/664530. WebAPKs shouldn't use a global ChildProcessCreationParams.
ChromeApplication chrome = (ChromeApplication) ContextUtils.getApplicationContext();
ChildProcessCreationParams params = chrome.getChildProcessCreationParams();
if (isForWebApk) {
- int extraBindFlag = params == null ? 0 : params.getExtraBindFlags();
+ boolean isExternalService = false;
params = new ChildProcessCreationParams(getWebappInfo().webApkPackageName(),
- extraBindFlag, LibraryProcessType.PROCESS_CHILD);
+ isExternalService, LibraryProcessType.PROCESS_CHILD);
}
ChildProcessCreationParams.set(params);
}

Powered by Google App Engine
This is Rietveld 408576698