android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java - Issue 2487673006: Fix bug: turns on BIND_EXTERNAL_SERVICE flag on Android N crashes WebAPK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Issue 2487673006: Fix bug: turns on BIND_EXTERNAL_SERVICE flag on Android N crashes WebAPK. (Closed)

Patch Set: Add a TODO. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

index c0446e1d211f2d36b1f41536ac7883a979059ba3..5681f9d560bdb4ed3bdb43b1ee89d8f95204ebd7 100644

--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

@@ -400,8 +400,8 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {

setUpResources(webViewPackageName, context);

initPlatSupportLibrary();

initNetworkChangeNotifier(context);

- final int extraBindFlags = Context.BIND_EXTERNAL_SERVICE;

- AwBrowserProcess.configureChildProcessLauncher(webViewPackageName, extraBindFlags);

+ final boolean isExternalService = true;

+ AwBrowserProcess.configureChildProcessLauncher(webViewPackageName, isExternalService);

AwBrowserProcess.start();

if (isBuildDebuggable()) {

« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java » ('j') | no next file with comments »