Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Issue 2487673006: Fix bug: turns on BIND_EXTERNAL_SERVICE flag on Android N crashes WebAPK. (Closed)
Patch Set: Add a TODO. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package com.android.webview.chromium; 5 package com.android.webview.chromium;
6 6
7 import android.Manifest; 7 import android.Manifest;
8 import android.app.ActivityManager; 8 import android.app.ActivityManager;
9 import android.content.ComponentCallbacks2; 9 import android.content.ComponentCallbacks2;
10 import android.content.Context; 10 import android.content.Context;
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 393
394 PathService.override(PathService.DIR_MODULE, "/system/lib/"); 394 PathService.override(PathService.DIR_MODULE, "/system/lib/");
395 PathService.override(DIR_RESOURCE_PAKS_ANDROID, "/system/framework/webvi ew/paks"); 395 PathService.override(DIR_RESOURCE_PAKS_ANDROID, "/system/framework/webvi ew/paks");
396 396
397 // Make sure that ResourceProvider is initialized before starting the br owser process. 397 // Make sure that ResourceProvider is initialized before starting the br owser process.
398 final String webViewPackageName = WebViewFactory.getLoadedPackageInfo(). packageName; 398 final String webViewPackageName = WebViewFactory.getLoadedPackageInfo(). packageName;
399 Context context = ContextUtils.getApplicationContext(); 399 Context context = ContextUtils.getApplicationContext();
400 setUpResources(webViewPackageName, context); 400 setUpResources(webViewPackageName, context);
401 initPlatSupportLibrary(); 401 initPlatSupportLibrary();
402 initNetworkChangeNotifier(context); 402 initNetworkChangeNotifier(context);
403 final int extraBindFlags = Context.BIND_EXTERNAL_SERVICE; 403 final boolean isExternalService = true;
404 AwBrowserProcess.configureChildProcessLauncher(webViewPackageName, extra BindFlags); 404 AwBrowserProcess.configureChildProcessLauncher(webViewPackageName, isExt ernalService);
405 AwBrowserProcess.start(); 405 AwBrowserProcess.start();
406 406
407 if (isBuildDebuggable()) { 407 if (isBuildDebuggable()) {
408 setWebContentsDebuggingEnabled(true); 408 setWebContentsDebuggingEnabled(true);
409 } 409 }
410 410
411 TraceEvent.setATraceEnabled(mWebViewDelegate.isTraceTagEnabled()); 411 TraceEvent.setATraceEnabled(mWebViewDelegate.isTraceTagEnabled());
412 mWebViewDelegate.setOnTraceEnabledChangeListener( 412 mWebViewDelegate.setOnTraceEnabledChangeListener(
413 new WebViewDelegate.OnTraceEnabledChangeListener() { 413 new WebViewDelegate.OnTraceEnabledChangeListener() {
414 @Override 414 @Override
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 this, HttpAuthDatabase.newInstance(context, HTTP_AUTH_DA TABASE_FILE)); 649 this, HttpAuthDatabase.newInstance(context, HTTP_AUTH_DA TABASE_FILE));
650 } 650 }
651 } 651 }
652 return mWebViewDatabase; 652 return mWebViewDatabase;
653 } 653 }
654 654
655 WebViewDelegate getWebViewDelegate() { 655 WebViewDelegate getWebViewDelegate() {
656 return mWebViewDelegate; 656 return mWebViewDelegate;
657 } 657 }
658 } 658 }
OLDNEW
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698