Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2487613002: Landing Recent QUIC changes until 12:43 PM, Nov 5, 2016 UTC+8 (Closed)

Created:
4 years, 1 month ago by Fan Yang
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 12:43 PM, Nov 5, 2016 UTC+8 There are no flags to be updated. Implement in-flight conservation in QUIC BBR. Protected by FLAGS_quic_allow_new_bbr. Merge internal change: 138264727 https://codereview.chromium.org/2479103002/ Delete unused, unimplemented CheckForAddressMigration declaration. Merge internal change: 138199910 https://codereview.chromium.org/2485553002/ Rename ReliableQuicStream to QuicStream. No behavior change, not protected. Merge internal change: 138194450 https://codereview.chromium.org/2480183002/ Deprecate FLAGS_quic_buffer_packet_till_chlo. Merge internal change: 138188583 https://codereview.chromium.org/2484603002/ Deprecate FLAGS_quic_reduce_sequencer_buffer_memory_life_time. Merge internal change: 138108562 https://codereview.chromium.org/2479083002/ Update a hyperlink in quic_crypto_stream.h to point to the publicly available crypto doc. Merge internal change: 138085207 https://codereview.chromium.org/2481123002/ Remove unused constructor of QuicPacketWriterWrapper Merge internal change: 138079930 https://codereview.chromium.org/2481113002/ Populate connection stats with the number of BLOCKED frames sent and received. Merge internal change: 138077328 https://codereview.chromium.org/2477273002/ Include send_algorithm_interface.h in tcp_cubic_sender_bytes_test.cc and tcp_cubic_sender_packets_test.cc. Include quic_session.h in quic_crypto_server_stream.cc Merge internal change: 137955026 https://codereview.chromium.org/2479073002/ Delete unused trailer_bytes_read() in quic_spdy_client_stream.h. Merge internal change: 137703540 https://codereview.chromium.org/2484583002/ Rewrite a DLOG message to make it more readable. Currently the output is: "Ignoring data in frame 5" which is odd because there is no "frame 5", it's data for "stream 5". Hopefully the rewording makes more sense. Merge internal change: 137699688 https://codereview.chromium.org/2481703002/ Committed: https://crrev.com/f66f9f1f8e2f2107c4cc2d83ebdf40b0315ffaa8 Cr-Commit-Position: refs/heads/master@{#430614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+667 lines, -2178 lines) Patch
M net/net.gypi View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/congestion_control/bbr_sender.h View 4 chunks +30 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender.cc View 8 chunks +60 lines, -2 lines 0 comments Download
M net/quic/core/congestion_control/bbr_sender_test.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_bytes_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_connection.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/core/quic_connection.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection_stats.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection_stats.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/core/quic_connection_test.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_stream.h View 2 chunks +12 lines, -12 lines 0 comments Download
M net/quic/core/quic_crypto_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_crypto_stream_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +1 line, -9 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_server_session_base.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_server_session_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/quic/core/quic_session.h View 6 chunks +12 lines, -13 lines 0 comments Download
M net/quic/core/quic_session.cc View 10 chunks +11 lines, -13 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 10 chunks +11 lines, -12 lines 0 comments Download
M net/quic/core/quic_spdy_stream.h View 4 chunks +5 lines, -5 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 7 chunks +7 lines, -8 lines 0 comments Download
M net/quic/core/quic_spdy_stream_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + net/quic/core/quic_stream.h View 4 chunks +12 lines, -12 lines 0 comments Download
A + net/quic/core/quic_stream.cc View 19 chunks +38 lines, -40 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/core/quic_stream_sequencer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer.h View 2 chunks +0 lines, -8 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_buffer_test.cc View 2 chunks +1 line, -7 lines 0 comments Download
M net/quic/core/quic_stream_sequencer_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download
A + net/quic/core/quic_stream_test.cc View 33 chunks +44 lines, -46 lines 0 comments Download
D net/quic/core/reliable_quic_stream.h View 1 chunk +0 lines, -321 lines 0 comments Download
D net/quic/core/reliable_quic_stream.cc View 1 chunk +0 lines, -480 lines 0 comments Download
D net/quic/core/reliable_quic_stream_test.cc View 1 chunk +0 lines, -717 lines 0 comments Download
M net/quic/quartc/quartc_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quartc/quartc_session.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M net/quic/quartc/quartc_stream.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/quartc/quartc_stream.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quartc/quartc_stream_test.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 3 chunks +5 lines, -7 lines 0 comments Download
A net/quic/test_tools/quic_stream_peer.h View 1 chunk +56 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_stream_peer.cc View 1 chunk +101 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_sequencer_buffer_peer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +5 lines, -7 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/quic/test_tools/reliable_quic_stream_peer.h View 1 chunk +0 lines, -57 lines 0 comments Download
D net/quic/test_tools/reliable_quic_stream_peer.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 15 chunks +78 lines, -111 lines 0 comments Download
M net/tools/quic/quic_client_base.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 6 chunks +3 lines, -24 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 7 chunks +4 lines, -43 lines 0 comments Download
M net/tools/quic/quic_packet_writer_wrapper.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_packet_writer_wrapper.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/tools/quic/quic_server.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 2 chunks +1 line, -4 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
Fan Yang
4 years, 1 month ago (2016-11-08 04:09:19 UTC) #7
Ryan Hamilton
lgtm
4 years, 1 month ago (2016-11-08 15:10:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487613002/1
4 years, 1 month ago (2016-11-08 15:10:16 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 15:26:11 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 15:28:29 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f66f9f1f8e2f2107c4cc2d83ebdf40b0315ffaa8
Cr-Commit-Position: refs/heads/master@{#430614}

Powered by Google App Engine
This is Rietveld 408576698