Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: net/quic/core/quic_stream_sequencer_buffer_test.cc

Issue 2487613002: Landing Recent QUIC changes until 12:43 PM, Nov 5, 2016 UTC+8 (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_stream_sequencer_buffer.cc ('k') | net/quic/core/quic_stream_sequencer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_stream_sequencer_buffer_test.cc
diff --git a/net/quic/core/quic_stream_sequencer_buffer_test.cc b/net/quic/core/quic_stream_sequencer_buffer_test.cc
index d7bf0815bf77ac24c1adcc6fabb7fe2b0128e25e..bc3025d42ac48c69a6b4ab17f09c1d24f8dca7a0 100644
--- a/net/quic/core/quic_stream_sequencer_buffer_test.cc
+++ b/net/quic/core/quic_stream_sequencer_buffer_test.cc
@@ -111,9 +111,7 @@ TEST_F(QuicStreamSequencerBufferTest, OnStreamData0length) {
}
TEST_F(QuicStreamSequencerBufferTest, OnStreamDataWithinBlock) {
- if (FLAGS_quic_reduce_sequencer_buffer_memory_life_time) { // NOLINT
- EXPECT_FALSE(helper_->IsBufferAllocated());
- }
+ EXPECT_FALSE(helper_->IsBufferAllocated());
string source(1024, 'a');
size_t written;
clock_.AdvanceTime(QuicTime::Delta::FromSeconds(1));
@@ -492,10 +490,6 @@ TEST_F(QuicStreamSequencerBufferTest, GetReadableRegionsEmpty) {
TEST_F(QuicStreamSequencerBufferTest, ReleaseWholeBuffer) {
// Tests that buffer is not deallocated unless ReleaseWholeBuffer() is called.
- if (!FLAGS_quic_reduce_sequencer_buffer_memory_life_time) { // NOLINT
- // Won't release buffer when flag is off.
- return;
- }
string source(100, 'b');
clock_.AdvanceTime(QuicTime::Delta::FromSeconds(1));
« no previous file with comments | « net/quic/core/quic_stream_sequencer_buffer.cc ('k') | net/quic/core/quic_stream_sequencer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698