Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: net/quic/core/quic_stream_sequencer_buffer.cc

Issue 2487613002: Landing Recent QUIC changes until 12:43 PM, Nov 5, 2016 UTC+8 (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_stream_sequencer_buffer.h ('k') | net/quic/core/quic_stream_sequencer_buffer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_stream_sequencer_buffer.cc
diff --git a/net/quic/core/quic_stream_sequencer_buffer.cc b/net/quic/core/quic_stream_sequencer_buffer.cc
index 01c7400c57a169f520e896005665ffc22a6186ce..e6bd9110390e11ca13743ddfccc53dc0a1eeab07 100644
--- a/net/quic/core/quic_stream_sequencer_buffer.cc
+++ b/net/quic/core/quic_stream_sequencer_buffer.cc
@@ -50,11 +50,7 @@ QuicStreamSequencerBuffer::QuicStreamSequencerBuffer(size_t max_capacity_bytes)
blocks_count_(
ceil(static_cast<double>(max_capacity_bytes) / kBlockSizeBytes)),
total_bytes_read_(0),
- reduce_sequencer_buffer_memory_life_time_(
- FLAGS_quic_reduce_sequencer_buffer_memory_life_time), // NOLINT
- blocks_(reduce_sequencer_buffer_memory_life_time_
- ? nullptr
- : new BufferBlock*[blocks_count_]()) {
+ blocks_(nullptr) {
Clear();
}
@@ -63,7 +59,7 @@ QuicStreamSequencerBuffer::~QuicStreamSequencerBuffer() {
}
void QuicStreamSequencerBuffer::Clear() {
- if (!reduce_sequencer_buffer_memory_life_time_ || blocks_ != nullptr) {
+ if (blocks_ != nullptr) {
for (size_t i = 0; i < blocks_count_; ++i) {
if (blocks_[i] != nullptr) {
RetireBlock(i);
@@ -181,7 +177,7 @@ QuicErrorCode QuicStreamSequencerBuffer::OnStreamData(
bytes_avail = total_bytes_read_ + max_buffer_capacity_bytes_ - offset;
}
- if (reduce_sequencer_buffer_memory_life_time_ && blocks_ == nullptr) {
+ if (blocks_ == nullptr) {
blocks_.reset(new BufferBlock*[blocks_count_]());
for (size_t i = 0; i < blocks_count_; ++i) {
blocks_[i] = nullptr;
@@ -462,10 +458,6 @@ size_t QuicStreamSequencerBuffer::FlushBufferedFrames() {
}
void QuicStreamSequencerBuffer::ReleaseWholeBuffer() {
- if (!reduce_sequencer_buffer_memory_life_time_) {
- // Don't release buffer if flag is off.
- return;
- }
Clear();
blocks_.reset(nullptr);
}
« no previous file with comments | « net/quic/core/quic_stream_sequencer_buffer.h ('k') | net/quic/core/quic_stream_sequencer_buffer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698