Chromium Code Reviews Chromium Code Reviews
Issue
2487433002:
Revert of Remove EventSender from HTMLStyleElement (Closed)
DescriptionRevert of Remove EventSender from HTMLStyleElement (patchset #20 id:380001 of https://codereview.chromium.org/2269043002/ )
Reason for revert:
This CL causes two layout tests to fail. See
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/39126
Original issue's description:
> Remove EventSender from HTMLStyleElement
>
> This CL replaces EventSender in HTMLLinkElement with postTask():
> Instead of calling HTMLStyleElement::dispatchPendingLoadEvents() in
> Document::implicitClose() to enforce <style>'s onload events to be executed
> before the document's onload event, this CL blocks document's onload until
> <style>'s onload event using IncrementLoadEventDelayCount.
>
> This CL changes the timing of body onload, particularly causes some of the
> following events that were previously called AFTER document onload
> to be called BEFORE document onload:
> [A] The first layout.
> [B] Latter half of FrameLoader::finishedParsing().
> [C] JavaScript function |f| scheduled as |setTimeout(f, 0)| in the <script>
> at the end of <body>.
>
> Notable test fixes (marked with the causes of failures):
>
> fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html:
> [A] Marked as flaky, because it depends on whether body onload is called
> before (Pass) or after (Failure) the first layout (crbug/651343).
>
> fast/scrolling/scrollbar-tickmarks-styled.html:
> [A] Fixed by https://codereview.chromium.org/2450793002.
>
> fast/scrolling/scrollbar-tickmarks-hittest.html:
> [A] Fixed by https://codereview.chromium.org/2484613003.
>
> virtual/rootlayerscrolls/fast/history/scroll-restoration/scroll-restoration-fragment-navigation-crossdoc.html:
> [B] Fixed by https://codereview.chromium.org/2467433002.
>
> svg/animations/animate-end-attribute-numeric-precision.html:
> [C] After this CL, calling executeTest() in
> svg/animations/script-tests/animate-end-attribute-numeric-precision.js
> causes sampleAnimation() to be called before document onload and test to fail.
> We set |animationStartsImmediately| true instead, in order to ensure the test
> is started in document onload.
>
> accessibility/inline-text-changes.html:
> [Race between the accessibility notification and document onload]
> Ignore the second call of the notification handler.
> Even before this CL, the notification is called multiple times, but the first
> notification terminated the test immediately by finishJSTest() because it is
> called after document onload.
> This CL makes the notification calls before document onload, and thus the test
> continues until document onload and we have to ignore the second call
> explicitly.
>
> fast/block/float/marquee-shrink-to-avoid-floats.html:
> The layout tree changes slightly, but it looks like acceptable because the
> image expectation matches.
>
> BUG=624697, 651343
>
> Committed: https://crrev.com/52d00fd56184deadce99ff4fe599156ea1da3543
> Cr-Commit-Position: refs/heads/master@{#430348}
TBR=haraken@chromium.org,kojii@chromium.org,japhet@chromium.org,yhirano@chromium.org,hiroshige@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624697, 651343
Committed: https://crrev.com/98116e47e7660b5ad3a71949efea694f96c1104e
Cr-Commit-Position: refs/heads/master@{#430366}
Patch Set 1 #Messages
Total messages: 9 (3 generated)
|
