Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2484613003:
Do not call internals.settings.setOverlayScrollbarsEnabled() in onload (Closed)
DescriptionDo not call internals.settings.setOverlayScrollbarsEnabled() in onload
internals.settings.setOverlayScrollbarsEnabled() doesn't work well when it is
called after ScrollbarTheme is initialized in the first layout.
The CL [1] modifies the timing of document load event and makes onload() in
fast/scrolling/scrollbar-tickmarks-hittest.html to be called after the first
layout, and thus breaks the test.
This CL moves setOverlayScrollbarsEnabled() to outside onload() such that it
is called before ScrollbarTheme is initialized.
[1] https://codereview.chromium.org/2269043002/
BUG=624697
TEST=fast/scrolling/scrollbar-tickmarks-hittest.html
Committed: https://crrev.com/6253bb13131f4afaba8140133b1b865487b82006
Cr-Commit-Position: refs/heads/master@{#430284}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 18 (13 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Do not call internals.settings.setOverlayScrollbarsEnabled() in onload internals.settings.setOverlayScrollbarsEnabled() doesn't work well when it is called after ScrollbarTheme is initialized in the first layout. The CL [1] modifies the timing of document load event and makes onload() in fast/scrolling/scrollbar-tickmarks-hittest.html to be called after the first layout, and thus breaks the test. This CL moves setOverlayScrollbarsEnabled() to outside onload() such that it is called before ScrollbarTheme is initialized. BUG= ========== to ========== Do not call internals.settings.setOverlayScrollbarsEnabled() in onload internals.settings.setOverlayScrollbarsEnabled() doesn't work well when it is called after ScrollbarTheme is initialized in the first layout. The CL [1] modifies the timing of document load event and makes onload() in fast/scrolling/scrollbar-tickmarks-hittest.html to be called after the first layout, and thus breaks the test. This CL moves setOverlayScrollbarsEnabled() to outside onload() such that it is called before ScrollbarTheme is initialized. [1] https://codereview.chromium.org/2269043002/ BUG=624697 TEST=fast/scrolling/scrollbar-tickmarks-hittest.html ==========
hiroshige@chromium.org changed reviewers: + bokan@chromium.org
Could you take a look?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Do not call internals.settings.setOverlayScrollbarsEnabled() in onload internals.settings.setOverlayScrollbarsEnabled() doesn't work well when it is called after ScrollbarTheme is initialized in the first layout. The CL [1] modifies the timing of document load event and makes onload() in fast/scrolling/scrollbar-tickmarks-hittest.html to be called after the first layout, and thus breaks the test. This CL moves setOverlayScrollbarsEnabled() to outside onload() such that it is called before ScrollbarTheme is initialized. [1] https://codereview.chromium.org/2269043002/ BUG=624697 TEST=fast/scrolling/scrollbar-tickmarks-hittest.html ========== to ========== Do not call internals.settings.setOverlayScrollbarsEnabled() in onload internals.settings.setOverlayScrollbarsEnabled() doesn't work well when it is called after ScrollbarTheme is initialized in the first layout. The CL [1] modifies the timing of document load event and makes onload() in fast/scrolling/scrollbar-tickmarks-hittest.html to be called after the first layout, and thus breaks the test. This CL moves setOverlayScrollbarsEnabled() to outside onload() such that it is called before ScrollbarTheme is initialized. [1] https://codereview.chromium.org/2269043002/ BUG=624697 TEST=fast/scrolling/scrollbar-tickmarks-hittest.html ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Do not call internals.settings.setOverlayScrollbarsEnabled() in onload internals.settings.setOverlayScrollbarsEnabled() doesn't work well when it is called after ScrollbarTheme is initialized in the first layout. The CL [1] modifies the timing of document load event and makes onload() in fast/scrolling/scrollbar-tickmarks-hittest.html to be called after the first layout, and thus breaks the test. This CL moves setOverlayScrollbarsEnabled() to outside onload() such that it is called before ScrollbarTheme is initialized. [1] https://codereview.chromium.org/2269043002/ BUG=624697 TEST=fast/scrolling/scrollbar-tickmarks-hittest.html ========== to ========== Do not call internals.settings.setOverlayScrollbarsEnabled() in onload internals.settings.setOverlayScrollbarsEnabled() doesn't work well when it is called after ScrollbarTheme is initialized in the first layout. The CL [1] modifies the timing of document load event and makes onload() in fast/scrolling/scrollbar-tickmarks-hittest.html to be called after the first layout, and thus breaks the test. This CL moves setOverlayScrollbarsEnabled() to outside onload() such that it is called before ScrollbarTheme is initialized. [1] https://codereview.chromium.org/2269043002/ BUG=624697 TEST=fast/scrolling/scrollbar-tickmarks-hittest.html Committed: https://crrev.com/6253bb13131f4afaba8140133b1b865487b82006 Cr-Commit-Position: refs/heads/master@{#430284} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6253bb13131f4afaba8140133b1b865487b82006 Cr-Commit-Position: refs/heads/master@{#430284} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
