Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.
(the test is marked as failing in rootlayerscrolls because the original
scrollbar-tickmarks-styled.html is already marked as failing.)

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
TEST=fast/scrolling/scrollbar-tickmarks-styled.html fast/scrolling/scrollbar-tickmarks-styled-after-onload.html

Committed: https://crrev.com/f768d0e471877996cf0dd06f2a3b1cb9ba49c6be
Cr-Commit-Position: refs/heads/master@{#429841}

[hiroshige, 2016-10-25 09:34:51]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 09:35:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-10-25 09:36:03]

Patchset #2 (id:20001) has been deleted

[hiroshige, 2016-10-25 09:36:35]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 09:36:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-10-25 09:42:25]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 09:42:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 11:02:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 11:02:27]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2016-10-31 06:57:28]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 06:57:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-10-31 07:15:53]

Description was changed from

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

BUG=
==========

to

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
==========

[hiroshige, 2016-10-31 07:16:21]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 07:16:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-10-31 07:21:47]

Patchset #5 (id:100001) has been deleted

[hiroshige, 2016-10-31 08:16:04]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 08:16:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-10-31 08:48:43]

hiroshige@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[hiroshige, 2016-10-31 09:15:44]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 09:15:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-10-31 09:16:54]

Description was changed from

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
==========

to

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.
(the test is marked as failing in rootlayerscrolls because the original
scrollbar-tickmarks-styled.html is already marked as failing.)

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
==========

[hiroshige, 2016-10-31 09:38:22]

Could you take a look?
(as you looks touched some related areas)

[commit-bot: I haz the power, 2016-10-31 12:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 12:27:21]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-10-31 15:59:07]

https://codereview.chromium.org/2450793002/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
(right):

https://codereview.chromium.org/2450793002/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-styled-after-onload.html:44:
<body onload="setTimeout(highlight, 0)">
Normally we use runAfterLayoutAndPaint(highlight, true) (requiring <script
src="../../resources/run-after-layout-and-paint.js"></script>) for this purpose.
It ensures not only layout, but also paint invalidation and paint (full document
cycle). I think this test needs the full document cycle, right? If you use it,
you can omit the most of the added lines.

[hiroshige, 2016-11-01 05:43:22]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 05:43:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-01 05:44:07]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2016-11-01 05:45:18]

Patchset #6 (id:140001) has been deleted

[hiroshige, 2016-11-01 05:45:32]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-11-01 05:45:38]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2016-11-01 05:45:43]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 05:45:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 05:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 05:45:46]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[hiroshige, 2016-11-01 05:48:04]

https://codereview.chromium.org/2450793002/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
(right):

https://codereview.chromium.org/2450793002/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-styled-after-onload.html:44:
<body onload="setTimeout(highlight, 0)">
On 2016/10/31 15:59:07, Xianzhu wrote:
> Normally we use runAfterLayoutAndPaint(highlight, true) (requiring <script
> src="../../resources/run-after-layout-and-paint.js"></script>) for this
purpose.
> It ensures not only layout, but also paint invalidation and paint (full
document
> cycle). I think this test needs the full document cycle, right? If you use it,
> you can omit the most of the added lines.

Thanks for suggestion!
I use runAfterLayoutAndPaint() in Patch Set 6, but the test crashing (assertion
failure due to under-invalidation check), even without my change to
Internals.cpp. Probably it is hitting another existing bug?

[Xianzhu, 2016-11-01 06:15:56]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 06:16:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-11-01 06:41:22]

https://codereview.chromium.org/2450793002/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
(right):

https://codereview.chromium.org/2450793002/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/fast/scrolling/scrollbar-tickmarks-styled-after-onload.html:44:
<body onload="setTimeout(highlight, 0)">
On 2016/11/01 05:48:04, hiroshige wrote:
> On 2016/10/31 15:59:07, Xianzhu wrote:
> > Normally we use runAfterLayoutAndPaint(highlight, true) (requiring <script
> > src="../../resources/run-after-layout-and-paint.js"></script>) for this
> purpose.
> > It ensures not only layout, but also paint invalidation and paint (full
> document
> > cycle). I think this test needs the full document cycle, right? If you use
it,
> > you can omit the most of the added lines.
> 
> Thanks for suggestion!
> I use runAfterLayoutAndPaint() in Patch Set 6, but the test crashing
(assertion
> failure due to under-invalidation check), even without my change to
> Internals.cpp. Probably it is hitting another existing bug?

The crash is expected without your patch because we don't invalidate paint in
Internals::addTextMatchMarker(). Actually I have been assigned cluster-fuzz bugs
about the crash, but I marked them WontFix because the crash was intentional: we
called into internal code which intentionally didn't do paint invalidation. We
expected the normal callers in production code to do it.

Your patch should fix the crash by letting Internal::addTextMatchMarker() do
paint invalidation. If there is still under-invalidation, then your patch seems
incomplete to fix the issue. I can help you to investigate it. I scheduled dry
run and will look at the results when it's available. 

BTW, does/will your patch fix scrollbar-tickmarks-styled.html?

https://codereview.chromium.org/2450793002/diff/140002/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/2450793002/diff/140002/third_party/WebKit/Sou...
third_party/WebKit/Source/core/testing/Internals.cpp:994:
range->ownerDocument().view()->invalidatePaintForTickmarks();
Please add a comment like: This simulates what the production code does after
addTextMatchMarker().

[commit-bot: I haz the power, 2016-11-01 08:39:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 08:39:56]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-11-01 15:56:14]

All trybots passed with your patch, so your patch fixed the under-invalidation.
lgtm.

[Xianzhu, 2016-11-01 15:58:30]

> 
> BTW, does/will your patch fix scrollbar-tickmarks-styled.html?
> 

Please ignore this. I thought the test also failed without rootLayerScrolls.

[hiroshige, 2016-11-04 07:47:31]

Description was changed from

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.
(the test is marked as failing in rootlayerscrolls because the original
scrollbar-tickmarks-styled.html is already marked as failing.)

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
==========

to

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.
(the test is marked as failing in rootlayerscrolls because the original
scrollbar-tickmarks-styled.html is already marked as failing.)

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
TEST=fast/scrolling/scrollbar-tickmarks-styled.html
==========

[hiroshige, 2016-11-04 07:59:48]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 08:00:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-11-04 08:00:54]

Description was changed from

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.
(the test is marked as failing in rootlayerscrolls because the original
scrollbar-tickmarks-styled.html is already marked as failing.)

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
TEST=fast/scrolling/scrollbar-tickmarks-styled.html
==========

to

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.
(the test is marked as failing in rootlayerscrolls because the original
scrollbar-tickmarks-styled.html is already marked as failing.)

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
TEST=fast/scrolling/scrollbar-tickmarks-styled.html
fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
==========

[commit-bot: I haz the power, 2016-11-04 09:24:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 09:24:50]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-11-04 09:28:06]

https://codereview.chromium.org/2450793002/diff/140002/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/testing/Internals.cpp (right):

https://codereview.chromium.org/2450793002/diff/140002/third_party/WebKit/Sou...
third_party/WebKit/Source/core/testing/Internals.cpp:994:
range->ownerDocument().view()->invalidatePaintForTickmarks();
On 2016/11/01 06:41:22, Xianzhu wrote:
> Please add a comment like: This simulates what the production code does after
> addTextMatchMarker().

Done.

[hiroshige, 2016-11-04 09:28:16]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-11-04 09:28:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2450793002/#ps160001
(title: "Add comment")

[commit-bot: I haz the power, 2016-11-04 09:28:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 09:33:53]

Description was changed from

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.
(the test is marked as failing in rootlayerscrolls because the original
scrollbar-tickmarks-styled.html is already marked as failing.)

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
TEST=fast/scrolling/scrollbar-tickmarks-styled.html
fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
==========

to

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.
(the test is marked as failing in rootlayerscrolls because the original
scrollbar-tickmarks-styled.html is already marked as failing.)

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
TEST=fast/scrolling/scrollbar-tickmarks-styled.html
fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
==========

[commit-bot: I haz the power, 2016-11-04 09:33:54]

Committed patchset #7 (id:160001)

[commit-bot: I haz the power, 2016-11-04 09:35:24]

Description was changed from

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.
(the test is marked as failing in rootlayerscrolls because the original
scrollbar-tickmarks-styled.html is already marked as failing.)

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
TEST=fast/scrolling/scrollbar-tickmarks-styled.html
fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
==========

to

==========
Call invalidatePaintForTickmarks() in Internals::addTextMatchMarker()

Callers of DocumentMarkerController::addTextMatchMarker() must invalidate
tickmarks (according a comment in addTextMatchMarker()) but
Internals::addTextMatchMarker() doesn't invalidate the tickmark.
This causes the fast/scrolling/scrollbar-tickmarks-styled.html test to fail
if internals.addTextMatchMarker() is called after the first layout.

This CL makes addTextMatchMarker() to do paint invalidation, just like
TextFinder does in TextFinder::invalidateIfNecessary and
TextFinder::finishCurrentScopingEffort().

This CL adds fast/scrolling/scrollbar-tickmarks-styled-after-onload.html
that tests internals.addTextMatchMarker() after the first layout and
document onload.
(the test is marked as failing in rootlayerscrolls because the original
scrollbar-tickmarks-styled.html is already marked as failing.)

This is preparation for https://codereview.chromium.org/2269043002
that modifies the timing of document onload event and moves document onload
after first layout in the test above.

BUG=624697
TEST=fast/scrolling/scrollbar-tickmarks-styled.html
fast/scrolling/scrollbar-tickmarks-styled-after-onload.html

Committed: https://crrev.com/f768d0e471877996cf0dd06f2a3b1cb9ba49c6be
Cr-Commit-Position: refs/heads/master@{#429841}
==========

[commit-bot: I haz the power, 2016-11-04 09:35:25]

Patchset 7 (id:??) landed as
https://crrev.com/f768d0e471877996cf0dd06f2a3b1cb9ba49c6be
Cr-Commit-Position: refs/heads/master@{#429841}