Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2486923005: Timeline: add moar attributes in frame instrumentation (Closed)

Created:
4 years, 1 month ago by caseq
Modified:
4 years, 1 month ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: add moar attributes in frame instrumentation BUG=662990 Committed: https://crrev.com/89769f616429bc2c18588cd4c33e32e34eb1143e Cr-Commit-Position: refs/heads/master@{#431651}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments addressed #

Patch Set 3 : rebased #

Messages

Total messages: 19 (10 generated)
caseq
4 years, 1 month ago (2016-11-11 00:52:35 UTC) #2
alph
lgtm https://codereview.chromium.org/2486923005/diff/1/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp File third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp (right): https://codereview.chromium.org/2486923005/diff/1/third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp#newcode1002 third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp:1002: fillCommonFrameData(value.get(), toLocalFrame(f)); you're gonna have two frame values.
4 years, 1 month ago (2016-11-11 02:22:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486923005/40001
4 years, 1 month ago (2016-11-11 02:51:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/333403)
4 years, 1 month ago (2016-11-11 02:53:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486923005/40001
4 years, 1 month ago (2016-11-11 03:54:04 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/302082) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-11 03:56:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486923005/60001
4 years, 1 month ago (2016-11-11 18:13:34 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 1 month ago (2016-11-11 21:34:54 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 21:45:04 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/89769f616429bc2c18588cd4c33e32e34eb1143e
Cr-Commit-Position: refs/heads/master@{#431651}

Powered by Google App Engine
This is Rietveld 408576698