Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2486923005: Timeline: add moar attributes in frame instrumentation (Closed)
Patch Set: rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
index 25cfa437eed2354bd39fb5ef74f359b5f7285d7f..fed5808cf1773877d4102f0120e2270ada957fb2 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -156,7 +156,7 @@ WebInspector.TimelineTreeView = class extends WebInspector.VBox {
}
/**
- * @param {function(!WebInspector.TracingModel.Event, string):(string|symbol)=} eventIdCallback
+ * @param {function(!WebInspector.TracingModel.Event):(string|symbol)=} eventIdCallback
* @return {!WebInspector.TimelineProfileTree.Node}
*/
_buildTopDownTree(eventIdCallback) {
@@ -611,7 +611,7 @@ WebInspector.AggregatedTimelineTreeView = class extends WebInspector.TimelineTre
/**
* @param {!WebInspector.AggregatedTimelineTreeView.GroupBy} groupBy
- * @return {function(!WebInspector.TracingModel.Event, string):string}
+ * @return {function(!WebInspector.TracingModel.Event):string}
*/
_groupingFunction(groupBy) {
/**
@@ -658,7 +658,7 @@ WebInspector.AggregatedTimelineTreeView = class extends WebInspector.TimelineTre
case WebInspector.AggregatedTimelineTreeView.GroupBy.URL:
return groupByURL;
case WebInspector.AggregatedTimelineTreeView.GroupBy.Frame:
- return (event, pageFrameId) => pageFrameId || '';
+ return event => WebInspector.TimelineData.forEvent(event).frameId;
default:
console.assert(false, `Unexpected aggregation setting: ${groupBy}`);
return () => Symbol('uniqueGroupId');

Powered by Google App Engine
This is Rietveld 408576698