Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js

Issue 2486923005: Timeline: add moar attributes in frame instrumentation (Closed)
Patch Set: rebased Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
index c1a09e7888ab6db8a1aa5398b7e08d79fffa131e..0f6114ba56ff7e7e4ab07f1f929c2e52912e129c 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineProfileTree.js
@@ -39,7 +39,7 @@ WebInspector.TimelineProfileTree.Node = class {
* @param {!Array<!WebInspector.TimelineModel.Filter>} filters
* @param {number} startTime
* @param {number} endTime
- * @param {function(!WebInspector.TracingModel.Event, string):string=} eventGroupIdCallback
+ * @param {function(!WebInspector.TracingModel.Event):string=} eventGroupIdCallback
* @return {!WebInspector.TimelineProfileTree.Node}
*/
WebInspector.TimelineProfileTree.buildTopDown = function(events, filters, startTime, endTime, eventGroupIdCallback) {
@@ -49,19 +49,16 @@ WebInspector.TimelineProfileTree.buildTopDown = function(events, filters, startT
root.totalTime = initialTime;
root.selfTime = initialTime;
root.children = /** @type {!Map<string, !WebInspector.TimelineProfileTree.Node>} */ (new Map());
- var pageFrameIdStack = [];
var parent = root;
/**
* @param {!WebInspector.TracingModel.Event} e
*/
function onStartEvent(e) {
- var pageFrameId = WebInspector.TimelineModel.eventFrameId(e) || pageFrameIdStack.peekLast();
- pageFrameIdStack.push(pageFrameId);
if (!WebInspector.TimelineModel.isVisible(filters, e))
return;
var time = e.endTime ? Math.min(endTime, e.endTime) - Math.max(startTime, e.startTime) : 0;
- var groupId = eventGroupIdCallback ? eventGroupIdCallback(e, pageFrameId) : Symbol('uniqueGroupId');
+ var groupId = eventGroupIdCallback ? eventGroupIdCallback(e) : Symbol('uniqueGroupId');
var id = eventGroupIdCallback ? WebInspector.TimelineProfileTree._eventId(e) : Symbol('uniqueEventId');
if (typeof groupId === 'string' && typeof id === 'string')
id += '/' + groupId;
@@ -94,7 +91,6 @@ WebInspector.TimelineProfileTree.buildTopDown = function(events, filters, startT
* @param {!WebInspector.TracingModel.Event} e
*/
function onEndEvent(e) {
- pageFrameIdStack.pop();
if (!WebInspector.TimelineModel.isVisible(filters, e))
return;
parent = parent.parent;
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698