Add keyboard explorer improvements for braille

Add keyboard explorer improvements for braille

- rename keyboard explorer to learn mode
- make the instructions focused on load so they get read (to let users know how to escape)
- read out the various types of braille commands, input dot patterns, and hardware keys (e.g. click on routing key 20, dots 2 4, etc).
- add a placeholder for gesture learn mode pending finalization of system gestures (e.g. ChromeVox toggle)
- make single character keys pitched to 0 previously pitched upward due to capping
- include all braille commands in Panel as chorded dot commands e.g. dot 1 chord, dots 1 2 3 chord, etc.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c15ee3e12286fc142e9d12e91134c1694772a205
Cr-Commit-Position: refs/heads/master@{#431190}

[David Tseng, 2016-11-09 21:17:50]

Description was changed from

==========
Add keyboard explorer improvements for braille

- rename keyboard explorer to learn mode
- make the instructions focused on load so they get read (to let users know how
to escape)
- read out the various types of braille commands, input dot patterns, and
hardware keys
- add a placeholder for gesture learn mode pending finalization of system
gestures (e.g. ChromeVox toggle)

BUG=
==========

to

==========
Add keyboard explorer improvements for braille

- rename keyboard explorer to learn mode
- make the instructions focused on load so they get read (to let users know how
to escape)
- read out the various types of braille commands, input dot patterns, and
hardware keys
- add a placeholder for gesture learn mode pending finalization of system
gestures (e.g. ChromeVox toggle)

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-11-09 21:18:10]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-11-09 22:18:52]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 22:19:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 23:36:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 23:36:05]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[David Tseng, 2016-11-10 00:14:41]

Description was changed from

==========
Add keyboard explorer improvements for braille

- rename keyboard explorer to learn mode
- make the instructions focused on load so they get read (to let users know how
to escape)
- read out the various types of braille commands, input dot patterns, and
hardware keys
- add a placeholder for gesture learn mode pending finalization of system
gestures (e.g. ChromeVox toggle)

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add keyboard explorer improvements for braille

- rename keyboard explorer to learn mode
- make the instructions focused on load so they get read (to let users know how
to escape)
- read out the various types of braille commands, input dot patterns, and
hardware keys (e.g. click on routing key 20, dots 2 4, etc).
- add a placeholder for gesture learn mode pending finalization of system
gestures (e.g. ChromeVox toggle)
- make single character keys pitched to 0 previously pitched upward due to
capping
- include all braille commands in Panel as chorded dot commands e.g. dot 1
chord, dots 1 2 3 chord, etc.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-11-10 01:22:05]

lgtm

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js
(right):

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js:51:
chrome.accessibilityPrivate.onAccessibilityGesture.removeListener(
nit: indent, this and next line

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js:118:
msgid = 'braille_pan_left';
I understand your reasons for not wanting to use the same key map that
we use for speech - but would it be possible to create a braille key map
and store the msgid for each one there, rather than having it split
across files like this?

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js:158:
text = Msgs.getMsg(msgid, msgArgs);
indent

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(left):

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:183:
Background.ISSUE_URL = 'https://code.google.com/p/chromium/issues/entry?' +
Did you mean to delete this as part of this change?

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js
(right):

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js:60:
while (shifter <= 7) {
This might be more clear as a for loop

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js:62:
dots.push(shifter + 1);
indent

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js:72:
var dotText = Msgs.getMsg(msgid, [dots.join(' ')]);
Would it work to join with hyphens or anything else?
Hyphens is what I see in most materials online.
But I understand if the speech feedback is bad.

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js:78:
return '';
indent

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
(right):

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js:161:
case 'reportIssue':
Oh, it moved here. This is fine.

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu_item.js
(right):

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu_item.js:41:
var braille = document.createElement('td');
It's going to get crowded showing all of these. How about we enable it based on
whether braille captions are on?

[David Tseng, 2016-11-10 04:56:58]

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js
(right):

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js:51:
chrome.accessibilityPrivate.onAccessibilityGesture.removeListener(
On 2016/11/10 01:22:04, dmazzoni wrote:
> nit: indent, this and next line

Done.

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js:118:
msgid = 'braille_pan_left';
On 2016/11/10 01:22:04, dmazzoni wrote:
> I understand your reasons for not wanting to use the same key map that
> we use for speech - but would it be possible to create a braille key map
> and store the msgid for each one there, rather than having it split
> across files like this?

Filed crbug.com/664010.

It's not quite that simple because we have lots of static data scattered
everywhere for key, braille, and gestures. I've proposed moving everything into
command store for the basic three types of mapping we're doing.

Of course, this still won't cover something dynamic like the thing below for
routing keys which isn't static data.

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/kbexplorer.js:158:
text = Msgs.getMsg(msgid, msgArgs);
On 2016/11/10 01:22:04, dmazzoni wrote:
> indent

Done.

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(left):

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:183:
Background.ISSUE_URL = 'https://code.google.com/p/chromium/issues/entry?' +
On 2016/11/10 01:22:04, dmazzoni wrote:
> Did you mean to delete this as part of this change?

Acknowledged.

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js
(right):

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js:60:
while (shifter <= 7) {
On 2016/11/10 01:22:04, dmazzoni wrote:
> This might be more clear as a for loop

Done.

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js:62:
dots.push(shifter + 1);
On 2016/11/10 01:22:04, dmazzoni wrote:
> indent

Done.

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js:72:
var dotText = Msgs.getMsg(msgid, [dots.join(' ')]);
On 2016/11/10 01:22:04, dmazzoni wrote:
> Would it work to join with hyphens or anything else?
> Hyphens is what I see in most materials online.
> But I understand if the speech feedback is bad.
> 

Done.

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
(right):

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js:161:
case 'reportIssue':
On 2016/11/10 01:22:05, dmazzoni wrote:
> Oh, it moved here. This is fine.

Acknowledged.

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu_item.js
(right):

https://codereview.chromium.org/2486293002/diff/60001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu_item.js:41:
var braille = document.createElement('td');
On 2016/11/10 01:22:05, dmazzoni wrote:
> It's going to get crowded showing all of these. How about we enable it based
on
> whether braille captions are on?

Good idea. Done.

[David Tseng, 2016-11-10 05:02:43]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-11-10 05:02:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2486293002/#ps80001
(title: "Indents and braille cap cond")

[commit-bot: I haz the power, 2016-11-10 05:02:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 05:54:16]

Description was changed from

==========
Add keyboard explorer improvements for braille

- rename keyboard explorer to learn mode
- make the instructions focused on load so they get read (to let users know how
to escape)
- read out the various types of braille commands, input dot patterns, and
hardware keys (e.g. click on routing key 20, dots 2 4, etc).
- add a placeholder for gesture learn mode pending finalization of system
gestures (e.g. ChromeVox toggle)
- make single character keys pitched to 0 previously pitched upward due to
capping
- include all braille commands in Panel as chorded dot commands e.g. dot 1
chord, dots 1 2 3 chord, etc.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add keyboard explorer improvements for braille

- rename keyboard explorer to learn mode
- make the instructions focused on load so they get read (to let users know how
to escape)
- read out the various types of braille commands, input dot patterns, and
hardware keys (e.g. click on routing key 20, dots 2 4, etc).
- add a placeholder for gesture learn mode pending finalization of system
gestures (e.g. ChromeVox toggle)
- make single character keys pitched to 0 previously pitched upward due to
capping
- include all braille commands in Panel as chorded dot commands e.g. dot 1
chord, dots 1 2 3 chord, etc.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-10 05:54:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-10 05:56:17]

Description was changed from

==========
Add keyboard explorer improvements for braille

- rename keyboard explorer to learn mode
- make the instructions focused on load so they get read (to let users know how
to escape)
- read out the various types of braille commands, input dot patterns, and
hardware keys (e.g. click on routing key 20, dots 2 4, etc).
- add a placeholder for gesture learn mode pending finalization of system
gestures (e.g. ChromeVox toggle)
- make single character keys pitched to 0 previously pitched upward due to
capping
- include all braille commands in Panel as chorded dot commands e.g. dot 1
chord, dots 1 2 3 chord, etc.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add keyboard explorer improvements for braille

- rename keyboard explorer to learn mode
- make the instructions focused on load so they get read (to let users know how
to escape)
- read out the various types of braille commands, input dot patterns, and
hardware keys (e.g. click on routing key 20, dots 2 4, etc).
- add a placeholder for gesture learn mode pending finalization of system
gestures (e.g. ChromeVox toggle)
- make single character keys pitched to 0 previously pitched upward due to
capping
- include all braille commands in Panel as chorded dot commands e.g. dot 1
chord, dots 1 2 3 chord, etc.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c15ee3e12286fc142e9d12e91134c1694772a205
Cr-Commit-Position: refs/heads/master@{#431190}
==========

[commit-bot: I haz the power, 2016-11-10 05:56:18]

Patchset 5 (id:??) landed as
https://crrev.com/c15ee3e12286fc142e9d12e91134c1694772a205
Cr-Commit-Position: refs/heads/master@{#431190}