Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js

Issue 2486293002: Add keyboard explorer improvements for braille (Closed)
Patch Set: Indents and braille cap cond Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
index 1cf338574d7c0449dd4441ae759c658b1e1fc0a8..d278914e685d0060d098ca11a107aff582f2b9e1 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js
@@ -77,8 +77,10 @@ PanelMenu.prototype = {
* @param {Function} callback The function to call if this item is selected.
* @return {!PanelMenuItem} The menu item just created.
*/
- addMenuItem: function(menuItemTitle, menuItemShortcut, callback) {
- var menuItem = new PanelMenuItem(menuItemTitle, menuItemShortcut, callback);
+ addMenuItem: function(
+ menuItemTitle, menuItemShortcut, menuItemBraille, callback) {
+ var menuItem = new PanelMenuItem(
+ menuItemTitle, menuItemShortcut, menuItemBraille, callback);
this.items_.push(menuItem);
this.menuElement.appendChild(menuItem.element);
@@ -308,7 +310,7 @@ PanelNodeMenu.prototype = {
var range = cursors.Range.fromNode(node);
output.withSpeech(range, range, Output.EventType.NAVIGATE);
var label = output.toString();
- this.addMenuItem(label, '', function() {
+ this.addMenuItem(label, '', '', function() {
chrome.extension.getBackgroundPage().ChromeVoxState
.instance['navigateToRange'](cursors.Range.fromNode(node));
});
@@ -338,7 +340,7 @@ PanelNodeMenu.prototype = {
finish_: function() {
if (!this.items_.length) {
this.addMenuItem(
- Msgs.getMsg('panel_menu_item_none'), '', function() {});
+ Msgs.getMsg('panel_menu_item_none'), '', '', function() {});
this.activateItem(0);
}
}

Powered by Google App Engine
This is Rietveld 408576698