Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

Issue 2486293002: Add keyboard explorer improvements for braille (Closed)
Patch Set: Indents and braille cap cond Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
index 565b21fd3098bc5dafe9bcae98ea07f0b43b58cc..2469aebac6fbd661f7ee73068b92949c83fa5296 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
@@ -8,6 +8,7 @@
goog.provide('Panel');
+goog.require('BrailleCommandHandler');
goog.require('ISearchUI');
goog.require('Msgs');
goog.require('PanelCommand');
@@ -362,6 +363,7 @@ Panel.onOpenMenus = function(opt_event, opt_activateMenuTitle) {
menu.addMenuItem(
binding.title,
binding.keySeq,
+ BrailleCommandHandler.getDotShortcut(binding.command, true),
function() {
var CommandHandler =
chrome.extension.getBackgroundPage()['CommandHandler'];
@@ -379,7 +381,7 @@ Panel.onOpenMenus = function(opt_event, opt_activateMenuTitle) {
var title = tabs[j].title;
if (tabs[j].active && windows[i].id == lastFocusedWindow.id)
title += ' ' + Msgs.getMsg('active_tab');
- tabsMenu.addMenuItem(title, '', (function(win, tab) {
+ tabsMenu.addMenuItem(title, '', '', (function(win, tab) {
bkgnd.chrome.windows.update(win.id, {focused: true}, function() {
bkgnd.chrome.tabs.update(tab.id, {active: true});
});
@@ -391,7 +393,7 @@ Panel.onOpenMenus = function(opt_event, opt_activateMenuTitle) {
// Add a menu item that disables / closes ChromeVox.
chromevoxMenu.addMenuItem(
- Msgs.getMsg('disable_chromevox'), 'Ctrl+Alt+Z', function() {
+ Msgs.getMsg('disable_chromevox'), 'Ctrl+Alt+Z', '', function() {
Panel.onClose();
});

Powered by Google App Engine
This is Rietveld 408576698