Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 2485963005: [Devtools] Fixed regression with linkifier regex (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed regression with linkifier regex This patch fixes an offending patch: https://codereview.chromium.org/2372303003 that caused devtools to be extremely slow when many slashes as a string were entered into console. BUG=663342 R=dgozman,pfeldman Committed: https://crrev.com/c45e5d718830df671d29c09104f0868b696d98a6 Cr-Commit-Position: refs/heads/master@{#431158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/inspector/components/linkifier.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
allada
PTL
4 years, 1 month ago (2016-11-09 23:00:57 UTC) #2
dgozman
lgtm
4 years, 1 month ago (2016-11-09 23:32:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485963005/1
4 years, 1 month ago (2016-11-10 01:25:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 03:10:32 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 03:13:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c45e5d718830df671d29c09104f0868b696d98a6
Cr-Commit-Position: refs/heads/master@{#431158}

Powered by Google App Engine
This is Rietveld 408576698