DevTools: introduce external service client (behind experiment).

DevTools: introduce external service client (behind experiment).

BUG=64980
NOPRESUBMIT=true

Committed: https://crrev.com/e0ac1e5319ddab7bdb47e0da7a43aa77bbd64fa3
Cr-Commit-Position: refs/heads/master@{#421701}

[pfeldman, 2016-09-27 19:16:03]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-09-27 19:25:48]

lgtm

https://codereview.chromium.org/2372303003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/terminal/TerminalWidget.js
(right):

https://codereview.chromium.org/2372303003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/terminal/TerminalWidget.js:25:
console.error("Terminal service not available.");
Let's show something instead of completely white widget.

https://codereview.chromium.org/2372303003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/terminal/TerminalWidget.js:71:
wasDetachedFromHierarchy: function()
Does this ever happen in the drawer?

[pfeldman, 2016-09-27 23:03:43]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-09-27 23:03:44]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-09-27 23:03:44]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2372303003/#ps60001
(title: "rebaselined")

[commit-bot: I haz the power, 2016-09-27 23:04:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 23:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 23:07:01]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-09-28 17:22:10]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-09-28 17:22:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2372303003/#ps80001
(title: "external linter")

[commit-bot: I haz the power, 2016-09-28 17:22:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 17:33:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 17:33:54]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-09-29 00:47:24]

Description was changed from

==========
DevTools: introduce external service client (behind experiment).

BUG=64980
==========

to

==========
DevTools: introduce external service client (behind experiment).

BUG=64980
NOPRESUBMIT=true
==========

[pfeldman, 2016-09-29 00:47:29]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-09-29 00:47:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 01:03:58]

Description was changed from

==========
DevTools: introduce external service client (behind experiment).

BUG=64980
NOPRESUBMIT=true
==========

to

==========
DevTools: introduce external service client (behind experiment).

BUG=64980
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-09-29 01:03:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-29 01:11:26]

Description was changed from

==========
DevTools: introduce external service client (behind experiment).

BUG=64980
NOPRESUBMIT=true
==========

to

==========
DevTools: introduce external service client (behind experiment).

BUG=64980
NOPRESUBMIT=true

Committed: https://crrev.com/e0ac1e5319ddab7bdb47e0da7a43aa77bbd64fa3
Cr-Commit-Position: refs/heads/master@{#421701}
==========

[commit-bot: I haz the power, 2016-09-29 01:11:28]

Patchset 5 (id:??) landed as
https://crrev.com/e0ac1e5319ddab7bdb47e0da7a43aa77bbd64fa3
Cr-Commit-Position: refs/heads/master@{#421701}

[wOxxOm, 2016-11-08 14:41:19]

woxxom@gmail.com changed reviewers:
+ pfeldman+blink@chromium.org, wOxxOm@gmail.com
- dgozman@chromium.org

[wOxxOm, 2016-11-08 14:41:21]

https://codereview.chromium.org/2372303003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/components/Linkifier.js
(right):

https://codereview.chromium.org/2372303003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components/Linkifier.js:474: var
linkString = linkStringRegEx.exec(string) || pathLineRegex.exec(string);
See https://crbug.com/663342 - pathLineRegex.exec freezes the devtools for
several seconds when logging long string of slashes like "/".repeat(40)