Use attach/detachLayoutTree to signal password counting

Use attach/detachLayoutTree to signal password counting

As a follow-up to https://codereview.chromium.org/2468833002/, use
attachLayoutTree/detachLayoutTree to count visible password fields on a
page, instead of subclassing LayoutObject.

BUG=658764
Committed: https://crrev.com/fda8404f14dba9919b4eb15e328459dfd45831c6
Cr-Commit-Position: refs/heads/master@{#430514}

[estark, 2016-11-08 01:40:08]

The CQ bit was checked by estark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 01:40:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estark, 2016-11-08 01:42:12]

estark@chromium.org changed reviewers:
+ tkent@chromium.org

[estark, 2016-11-08 01:42:12]

tkent, PTAL?

I added new InputType methods to call into PasswordInputType from
HTMLInputElement::attachLayoutTree and detachLayoutTree. Do you prefer having an
InputType::isPasswordField and doing the incrementing/decrementing inside
HTMLInputElement? I think it's kind of nice to have all the password counting
logic inside PasswordInputType and not cluttering HTMLInputElement with that
password-specific logic. Let me know what you think.

[tkent, 2016-11-08 01:48:10]

On 2016/11/08 at 01:42:12, estark wrote:
> tkent, PTAL?
> 
> I added new InputType methods to call into PasswordInputType from
HTMLInputElement::attachLayoutTree and detachLayoutTree. Do you prefer having an
InputType::isPasswordField and doing the incrementing/decrementing inside
HTMLInputElement? I think it's kind of nice to have all the password counting
logic inside PasswordInputType and not cluttering HTMLInputElement with that
password-specific logic. Let me know what you think.

lgtm.  I prefer this CL to isPasswordField().

[commit-bot: I haz the power, 2016-11-08 01:54:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 01:54:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[estark, 2016-11-08 02:49:28]

Thanks!

[estark, 2016-11-08 02:49:52]

The CQ bit was checked by estark@chromium.org

[estark, 2016-11-08 02:49:53]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2485803002/#ps20001
(title: "fix DCHECK_GT")

[commit-bot: I haz the power, 2016-11-08 02:50:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 04:03:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-08 04:11:38]

Description was changed from

==========
Use attach/detachLayoutTree to signal password counting

As a follow-up to https://codereview.chromium.org/2468833002/, use
attachLayoutTree/detachLayoutTree to count visible password fields on a
page, instead of subclassing LayoutObject.

BUG=658764
==========

to

==========
Use attach/detachLayoutTree to signal password counting

As a follow-up to https://codereview.chromium.org/2468833002/, use
attachLayoutTree/detachLayoutTree to count visible password fields on a
page, instead of subclassing LayoutObject.

BUG=658764

Committed: https://crrev.com/fda8404f14dba9919b4eb15e328459dfd45831c6
Cr-Commit-Position: refs/heads/master@{#430514}
==========

[commit-bot: I haz the power, 2016-11-08 04:11:39]

Patchset 2 (id:??) landed as
https://crrev.com/fda8404f14dba9919b4eb15e328459dfd45831c6
Cr-Commit-Position: refs/heads/master@{#430514}