Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2485803002: Use attach/detachLayoutTree to signal password counting (Closed)
Patch Set: fix DCHECK_GT Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
index 30d095c3992bb071d24282013eb7667dbea0056a..3af1302dea58d8028451e9e5f042cf8f13b9c56e 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
@@ -852,6 +852,9 @@ LayoutObject* HTMLInputElement::createLayoutObject(const ComputedStyle& style) {
void HTMLInputElement::attachLayoutTree(const AttachContext& context) {
HTMLTextFormControlElement::attachLayoutTree(context);
+ if (layoutObject()) {
+ m_inputType->onAttachWithLayoutObject();
+ }
m_inputTypeView->startResourceLoading();
m_inputType->countUsage();
@@ -861,6 +864,9 @@ void HTMLInputElement::attachLayoutTree(const AttachContext& context) {
}
void HTMLInputElement::detachLayoutTree(const AttachContext& context) {
+ if (layoutObject()) {
+ m_inputType->onDetachWithLayoutObject();
+ }
HTMLTextFormControlElement::detachLayoutTree(context);
m_needsToUpdateViewValue = true;
m_inputTypeView->closePopupView();
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/html/forms/InputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698