third_party/WebKit/Source/core/html/forms/PasswordInputType.h - Issue 2485803002: Use attach/detachLayoutTree to signal password counting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/PasswordInputType.h

Issue 2485803002: Use attach/detachLayoutTree to signal password counting (Closed)

Patch Set: fix DCHECK_GT Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/PasswordInputType.h

diff --git a/third_party/WebKit/Source/core/html/forms/PasswordInputType.h b/third_party/WebKit/Source/core/html/forms/PasswordInputType.h

index 4976e49ae3ef793d4797559f4b6633770c0d532c..220411cfbb582970d8f62abf6705d50a6da65333 100644

--- a/third_party/WebKit/Source/core/html/forms/PasswordInputType.h

+++ b/third_party/WebKit/Source/core/html/forms/PasswordInputType.h

@@ -50,7 +50,8 @@ class PasswordInputType final : public BaseTextInputType {

bool shouldRespectListAttribute() override;

void enableSecureTextInput() override;

void disableSecureTextInput() override;

- LayoutObject* createLayoutObject(const ComputedStyle&) const override;

+ void onAttachWithLayoutObject() override;

+ void onDetachWithLayoutObject() override;

};

} // namespace blink