Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2485633004: Revert of DevTools: Make WorkerThreadDebugger available for Worklets (Closed)

Created:
4 years, 1 month ago by xlai (Olivia)
Modified:
4 years, 1 month ago
Reviewers:
falken, haraken, dgozman, nhiroki
CC:
chromium-reviews, shans, tzik, apavlov+blink_chromium.org, kinuko+worker_chromium.org, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, hongchan, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, falken+watch_chromium.org, blink-worker-reviews_chromium.org, Eric Willigers, rjwright, lushnikov+blink_chromium.org, Raymond Toy, darktears, michaeln, shimazu+serviceworker_chromium.org, blink-reviews-animation_chromium.org, serviceworker-reviews, shimazu+worker_chromium.org, pfeldman+blink_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, kozyatinskiy+blink_chromium.org, ikilpatrick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: Make WorkerThreadDebugger available for Worklets (patchset #8 id:360001 of https://codereview.chromium.org/2456733002/ ) Reason for revert: The layout test animation-worklet-console.html is failing on WebKit Linux Precise Leak bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1566 Original issue's description: > DevTools: Make WorkerThreadDebugger available for Worklets > > DevTools is now disabled on Worklets because worker's debugger infrastructure(*) > cannot host multiple worklet execution contexts on a single thread. > (*) Worklet has been implemented on the worker infrastructure. > > To support it, this CL does following things: > > - This expands 1:1 relationship between WorkerThreadDebugger and WorkerThread to > 1:M relationship. The debugger has a ID-WorkerThread map to manage multiple > WorkerThreads. WorkerThread is added when worklet context is created and > removed when the context is destroyed. > > - This decouples lifetime of WorkerThreadDebugger from lifetime of worklet > context. Before this CL, the debugger has the same lifetime of the context. > This prevents the debugger from hosting multiple contexts. After this CL, > the debugger has the same lifetime of WorkerBackingThread, and attaches to > worklet context when it's created. > > DesignDoc: https://docs.google.com/document/d/1v0dNB6jWMe7w6OeK-Vlnn-Q4qW7KI4m97LGnMefUx1k/edit > > BUG=646559 > > Committed: https://crrev.com/46d040e09230a0a04c61fc06d88636b9c3dfb627 > Cr-Commit-Position: refs/heads/master@{#430558} TBR=dgozman@chromium.org,falken@chromium.org,haraken@chromium.org,nhiroki@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOTREECHECKS=true NOTRY=true BUG=646559 Committed: https://crrev.com/c023fcba8a6c9ca521c4c2a9f8921beaab18604e Cr-Commit-Position: refs/heads/master@{#430638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -181 lines) Patch
D third_party/WebKit/LayoutTests/http/tests/worklet/chromium/README.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/worklet/chromium/paint-worklet-console.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/worklet/chromium/paint-worklet-console-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/worklet/chromium/resources/console-tests.js View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/worklet/chromium/resources/console-worklet-script.js View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/chromium/README.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/chromium/animation-worklet-console.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/chromium/animation-worklet-console-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt View 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 6 chunks +36 lines, -62 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.h View 3 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 5 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
xlai (Olivia)
Created Revert of DevTools: Make WorkerThreadDebugger available for Worklets
4 years, 1 month ago (2016-11-08 16:51:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485633004/1
4 years, 1 month ago (2016-11-08 16:53:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 16:59:05 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c023fcba8a6c9ca521c4c2a9f8921beaab18604e Cr-Commit-Position: refs/heads/master@{#430638}
4 years, 1 month ago (2016-11-08 17:05:37 UTC) #8
haraken
4 years, 1 month ago (2016-11-08 23:34:46 UTC) #9
Message was sent while issue was closed.
LGTM to revert

Powered by Google App Engine
This is Rietveld 408576698