third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp - Issue 2485633004: Revert of DevTools: Make WorkerThreadDebugger available for Worklets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp

Issue 2485633004: Revert of DevTools: Make WorkerThreadDebugger available for Worklets (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp b/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp

index 0be4de585a9228d46101cadd2d80e1926122fe35..eacb451db831628a938141c33529a5f1375a910b 100644

--- a/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp

@@ -32,8 +32,9 @@

void ThreadedWorkletGlobalScope::dispose() {

DCHECK(isContextThread());

+ m_thread = nullptr;

WorkletGlobalScope::dispose();

- m_thread = nullptr;

}

bool ThreadedWorkletGlobalScope::isContextThread() const {

@@ -61,7 +62,7 @@

DCHECK(isContextThread());

if (WorkerThreadDebugger* debugger =

WorkerThreadDebugger::from(thread()->isolate()))

- debugger->exceptionThrown(m_thread, errorEvent);

+ debugger->exceptionThrown(errorEvent);

}

} // namespace blink