ui/platform_window/android/platform_ime_controller_android.cc - Issue 2485513003: Rename JavaObjectWeakGlobalRef::is_empty to avoid misuse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/platform_window/android/platform_ime_controller_android.cc

Issue 2485513003: Rename JavaObjectWeakGlobalRef::is_empty to avoid misuse. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/platform_window/android/platform_ime_controller_android.cc

diff --git a/ui/platform_window/android/platform_ime_controller_android.cc b/ui/platform_window/android/platform_ime_controller_android.cc

index 377baae7c9b1e3cafbf5aa790b3ef2179e36df81..d9e0edfb4daadca99cebe19d0ef9875d27fbc5ba 100644

--- a/ui/platform_window/android/platform_ime_controller_android.cc

+++ b/ui/platform_window/android/platform_ime_controller_android.cc

@@ -26,7 +26,7 @@ PlatformImeControllerAndroid::~PlatformImeControllerAndroid() {

void PlatformImeControllerAndroid::Init(JNIEnv* env,

const JavaParamRef<jobject>& jobj) {

- DCHECK(java_platform_ime_controller_android_.is_empty());

+ DCHECK(java_platform_ime_controller_android_.is_uninitialized());

java_platform_ime_controller_android_ = JavaObjectWeakGlobalRef(env, jobj);

}