Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: content/browser/android/java/gin_java_method_invocation_helper.cc

Issue 2485513003: Rename JavaObjectWeakGlobalRef::is_empty to avoid misuse. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/java/gin_java_method_invocation_helper.cc
diff --git a/content/browser/android/java/gin_java_method_invocation_helper.cc b/content/browser/android/java/gin_java_method_invocation_helper.cc
index 9c9cc09bdeb6a8dbbc757927f0ca0ae46b5afeb1..a2e73ef2d695803b7551dd98a808f574d52d0652 100644
--- a/content/browser/android/java/gin_java_method_invocation_helper.cc
+++ b/content/browser/android/java/gin_java_method_invocation_helper.cc
@@ -100,7 +100,7 @@ bool GinJavaMethodInvocationHelper::AppendObjectRef(
if (iter == object_refs_.end()) {
JavaObjectWeakGlobalRef object_ref(
dispatcher->GetObjectWeakRef(object_id));
- if (!object_ref.is_empty()) {
+ if (!object_ref.is_uninitialized()) {
object_refs_.insert(std::make_pair(object_id, object_ref));
}
}

Powered by Google App Engine
This is Rietveld 408576698