Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Side by Side Diff: ui/platform_window/android/platform_ime_controller_android.cc

Issue 2485513003: Rename JavaObjectWeakGlobalRef::is_empty to avoid misuse. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/platform_window/android/platform_ime_controller_android.h" 5 #include "ui/platform_window/android/platform_ime_controller_android.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "jni/PlatformImeControllerAndroid_jni.h" 9 #include "jni/PlatformImeControllerAndroid_jni.h"
10 10
11 using base::android::JavaParamRef; 11 using base::android::JavaParamRef;
12 using base::android::ScopedJavaLocalRef; 12 using base::android::ScopedJavaLocalRef;
13 13
14 namespace ui { 14 namespace ui {
15 15
16 // static 16 // static
17 bool PlatformImeControllerAndroid::Register(JNIEnv* env) { 17 bool PlatformImeControllerAndroid::Register(JNIEnv* env) {
18 return RegisterNativesImpl(env); 18 return RegisterNativesImpl(env);
19 } 19 }
20 20
21 PlatformImeControllerAndroid::PlatformImeControllerAndroid() { 21 PlatformImeControllerAndroid::PlatformImeControllerAndroid() {
22 } 22 }
23 23
24 PlatformImeControllerAndroid::~PlatformImeControllerAndroid() { 24 PlatformImeControllerAndroid::~PlatformImeControllerAndroid() {
25 } 25 }
26 26
27 void PlatformImeControllerAndroid::Init(JNIEnv* env, 27 void PlatformImeControllerAndroid::Init(JNIEnv* env,
28 const JavaParamRef<jobject>& jobj) { 28 const JavaParamRef<jobject>& jobj) {
29 DCHECK(java_platform_ime_controller_android_.is_empty()); 29 DCHECK(java_platform_ime_controller_android_.is_uninitialized());
30 java_platform_ime_controller_android_ = JavaObjectWeakGlobalRef(env, jobj); 30 java_platform_ime_controller_android_ = JavaObjectWeakGlobalRef(env, jobj);
31 } 31 }
32 32
33 void PlatformImeControllerAndroid::UpdateTextInputState( 33 void PlatformImeControllerAndroid::UpdateTextInputState(
34 const TextInputState& state) { 34 const TextInputState& state) {
35 JNIEnv* env = base::android::AttachCurrentThread(); 35 JNIEnv* env = base::android::AttachCurrentThread();
36 ScopedJavaLocalRef<jobject> scoped_obj = 36 ScopedJavaLocalRef<jobject> scoped_obj =
37 java_platform_ime_controller_android_.get(env); 37 java_platform_ime_controller_android_.get(env);
38 if (scoped_obj.is_null()) 38 if (scoped_obj.is_null())
39 return; 39 return;
40 Java_PlatformImeControllerAndroid_updateTextInputState( 40 Java_PlatformImeControllerAndroid_updateTextInputState(
41 env, scoped_obj, state.type, state.flags, 41 env, scoped_obj, state.type, state.flags,
42 base::android::ConvertUTF8ToJavaString(env, state.text), 42 base::android::ConvertUTF8ToJavaString(env, state.text),
43 state.selection_start, state.selection_end, state.composition_start, 43 state.selection_start, state.selection_end, state.composition_start,
44 state.composition_end); 44 state.composition_end);
45 } 45 }
46 46
47 void PlatformImeControllerAndroid::SetImeVisibility(bool visible) { 47 void PlatformImeControllerAndroid::SetImeVisibility(bool visible) {
48 JNIEnv* env = base::android::AttachCurrentThread(); 48 JNIEnv* env = base::android::AttachCurrentThread();
49 ScopedJavaLocalRef<jobject> scoped_obj = 49 ScopedJavaLocalRef<jobject> scoped_obj =
50 java_platform_ime_controller_android_.get(env); 50 java_platform_ime_controller_android_.get(env);
51 if (scoped_obj.is_null()) 51 if (scoped_obj.is_null())
52 return; 52 return;
53 Java_PlatformImeControllerAndroid_setImeVisibility(env, scoped_obj, visible); 53 Java_PlatformImeControllerAndroid_setImeVisibility(env, scoped_obj, visible);
54 } 54 }
55 55
56 } // namespace ui 56 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698