|
[Interpreter] Remove Ldr[Named/Keyed]Property bytecodes and use Star Lookahead instead.
The Ldr[Named/Keyed]Property bytecodes are problematic for the deoptimizer when
inlining accessors in TurboFan. Remove them and replace with a Star lookahead
in the bytecode handlers for Lda[Named/Keyed]Property.
BUG= v8:4280
Committed: https://crrev.com/ed35983ab78ad52bce6ef37c74b4c1fd6e447525
Cr-Commit-Position: refs/heads/master@{#40860}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+687 lines, -782 lines) |
Patch |
|
M |
src/compiler/bytecode-graph-builder.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/compiler/bytecode-graph-builder.cc
|
View
|
|
3 chunks |
+5 lines, -27 lines |
0 comments
|
Download
|
|
M |
src/interpreter/bytecodes.h
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/interpreter/bytecodes.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/interpreter/interpreter.h
|
View
|
|
1 chunk |
+0 lines, -8 lines |
0 comments
|
Download
|
|
M |
src/interpreter/interpreter.cc
|
View
|
|
3 chunks |
+13 lines, -47 lines |
0 comments
|
Download
|
|
M |
src/interpreter/mkpeephole.cc
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden
|
View
|
|
3 chunks |
+8 lines, -5 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden
|
View
|
|
8 chunks |
+12 lines, -8 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/CompoundExpressions.golden
|
View
|
|
2 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/CreateRestParameter.golden
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/ForIn.golden
|
View
|
|
1 chunk |
+11 lines, -9 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/ForOf.golden
|
View
|
|
22 chunks |
+64 lines, -47 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/Generators.golden
|
View
|
|
10 chunks |
+23 lines, -23 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/Modules.golden
|
View
|
|
4 chunks |
+8 lines, -5 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/PropertyCall.golden
|
View
|
|
4 chunks |
+11 lines, -8 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden
|
View
|
|
3 chunks |
+517 lines, -517 lines |
0 comments
|
Download
|
|
M |
test/cctest/interpreter/bytecode_expectations/RegExpLiterals.golden
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
test/unittests/interpreter/bytecode-array-builder-unittest.cc
|
View
|
|
2 chunks |
+1 line, -7 lines |
0 comments
|
Download
|
|
M |
test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc
|
View
|
|
1 chunk |
+0 lines, -51 lines |
0 comments
|
Download
|
Dependent Patchsets:
Total messages: 14 (7 generated)
|