Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2485383002: [Interpreter] Remove Ldr[Named/Keyed]Property bytecodes and use Star Lookahead instead. (Closed)

Created:
4 years, 1 month ago by rmcilroy
Modified:
4 years, 1 month ago
Reviewers:
Jarin, mythria
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Remove Ldr[Named/Keyed]Property bytecodes and use Star Lookahead instead. The Ldr[Named/Keyed]Property bytecodes are problematic for the deoptimizer when inlining accessors in TurboFan. Remove them and replace with a Star lookahead in the bytecode handlers for Lda[Named/Keyed]Property. BUG=v8:4280 Committed: https://crrev.com/ed35983ab78ad52bce6ef37c74b4c1fd6e447525 Cr-Commit-Position: refs/heads/master@{#40860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+687 lines, -782 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 3 chunks +5 lines, -27 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/interpreter/bytecodes.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/interpreter/interpreter.cc View 3 chunks +13 lines, -47 lines 0 comments Download
M src/interpreter/mkpeephole.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassAndSuperClass.golden View 3 chunks +8 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 8 chunks +12 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CompoundExpressions.golden View 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CreateRestParameter.golden View 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForIn.golden View 1 chunk +11 lines, -9 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForOf.golden View 22 chunks +64 lines, -47 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 10 chunks +23 lines, -23 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Modules.golden View 4 chunks +8 lines, -5 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyCall.golden View 4 chunks +11 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/PropertyLoads.golden View 3 chunks +517 lines, -517 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/RegExpLiterals.golden View 1 chunk +3 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
rmcilroy
Jaro / Mythri, PTAL. I'll see what the perf bots come back with before landing.
4 years, 1 month ago (2016-11-09 11:15:46 UTC) #4
Jarin
lgtm. I verified it fixes the tests that would fail with accessor inlining (well, one ...
4 years, 1 month ago (2016-11-09 11:59:04 UTC) #7
mythria
lgtm.
4 years, 1 month ago (2016-11-09 12:02:38 UTC) #8
rmcilroy
Perf numbers look good on the try-bots so let's land this and see how it ...
4 years, 1 month ago (2016-11-09 13:13:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485383002/1
4 years, 1 month ago (2016-11-09 13:13:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 13:16:08 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:27:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed35983ab78ad52bce6ef37c74b4c1fd6e447525
Cr-Commit-Position: refs/heads/master@{#40860}

Powered by Google App Engine
This is Rietveld 408576698