Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2001)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/ForOf.golden

Issue 2485383002: [Interpreter] Remove Ldr[Named/Keyed]Property bytecodes and use Star Lookahead instead. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/ForIn.golden ('k') | test/cctest/interpreter/bytecode_expectations/Generators.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/ForOf.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/ForOf.golden b/test/cctest/interpreter/bytecode_expectations/ForOf.golden
index aaa7666e91c2c574427469c7ad06246be4a3a1b1..2f01097a205e06516a92f2f56a7620536560217f 100644
--- a/test/cctest/interpreter/bytecode_expectations/ForOf.golden
+++ b/test/cctest/interpreter/bytecode_expectations/ForOf.golden
@@ -11,7 +11,7 @@ snippet: "
"
frame size: 15
parameter count: 1
-bytecode array length: 277
+bytecode array length: 281
bytecodes: [
/* 30 E> */ B(StackCheck),
B(LdaZero),
@@ -21,10 +21,12 @@ bytecodes: [
/* 48 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(9),
B(Star), R(14),
B(LdaConstant), U8(1),
- /* 48 E> */ B(LdrKeyedProperty), R(14), U8(4), R(13),
+ /* 48 E> */ B(LdaKeyedProperty), R(14), U8(4),
+ B(Star), R(13),
/* 48 E> */ B(CallProperty), R(13), R(14), U8(1), U8(2),
B(Star), R(2),
- /* 45 S> */ B(LdrNamedProperty), R(2), U8(2), U8(8), R(14),
+ /* 45 S> */ B(LdaNamedProperty), R(2), U8(2), U8(8),
+ B(Star), R(14),
/* 45 E> */ B(CallProperty), R(14), R(2), U8(1), U8(6),
B(Star), R(3),
/* 45 E> */ B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(3), U8(1),
@@ -32,8 +34,9 @@ bytecodes: [
B(JumpIfFalse), U8(7),
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(3), U8(1),
B(LdaNamedProperty), R(3), U8(3), U8(10),
- B(JumpIfToBooleanTrue), U8(24),
- B(LdrNamedProperty), R(3), U8(4), U8(12), R(5),
+ B(JumpIfToBooleanTrue), U8(25),
+ B(LdaNamedProperty), R(3), U8(4), U8(12),
+ B(Star), R(5),
B(LdaSmi), U8(2),
B(Star), R(4),
B(Mov), R(5), R(0),
@@ -41,7 +44,7 @@ bytecodes: [
B(Mov), R(0), R(1),
B(LdaZero),
B(Star), R(4),
- B(JumpLoop), U8(-49), U8(0),
+ B(JumpLoop), U8(-51), U8(0),
B(Jump), U8(35),
B(Star), R(13),
B(Ldar), R(closure),
@@ -66,11 +69,12 @@ bytecodes: [
B(Star), R(11),
B(LdaZero),
B(TestEqualStrict), R(4), U8(15),
- B(JumpIfTrue), U8(121),
+ B(JumpIfTrue), U8(122),
B(LdaUndefined),
B(TestEqualStrict), R(2), U8(16),
- B(JumpIfTrue), U8(115),
- B(LdrNamedProperty), R(2), U8(7), U8(17), R(6),
+ B(JumpIfTrue), U8(116),
+ B(LdaNamedProperty), R(2), U8(7), U8(17),
+ B(Star), R(6),
B(LdaNull),
B(TestEqual), R(6), U8(19),
B(JumpIfFalse), U8(4),
@@ -137,9 +141,9 @@ constant pool: [
FIXED_ARRAY_TYPE,
]
handlers: [
- [7, 116, 122],
- [10, 81, 83],
- [199, 209, 211],
+ [7, 119, 125],
+ [10, 84, 86],
+ [203, 213, 215],
]
---
@@ -149,7 +153,7 @@ snippet: "
"
frame size: 16
parameter count: 1
-bytecode array length: 288
+bytecode array length: 292
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaConstant), U8(0),
@@ -159,10 +163,12 @@ bytecodes: [
B(Mov), R(context), R(12),
B(Mov), R(context), R(13),
/* 68 S> */ B(LdaConstant), U8(1),
- /* 68 E> */ B(LdrKeyedProperty), R(0), U8(4), R(14),
+ /* 68 E> */ B(LdaKeyedProperty), R(0), U8(4),
+ B(Star), R(14),
/* 68 E> */ B(CallProperty), R(14), R(0), U8(1), U8(2),
B(Star), R(3),
- /* 65 S> */ B(LdrNamedProperty), R(3), U8(2), U8(8), R(15),
+ /* 65 S> */ B(LdaNamedProperty), R(3), U8(2), U8(8),
+ B(Star), R(15),
/* 65 E> */ B(CallProperty), R(15), R(3), U8(1), U8(6),
B(Star), R(4),
/* 65 E> */ B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(4), U8(1),
@@ -170,8 +176,9 @@ bytecodes: [
B(JumpIfFalse), U8(7),
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(4), U8(1),
B(LdaNamedProperty), R(4), U8(3), U8(10),
- B(JumpIfToBooleanTrue), U8(26),
- B(LdrNamedProperty), R(4), U8(4), U8(12), R(6),
+ B(JumpIfToBooleanTrue), U8(27),
+ B(LdaNamedProperty), R(4), U8(4), U8(12),
+ B(Star), R(6),
B(LdaSmi), U8(2),
B(Star), R(5),
B(Mov), R(6), R(1),
@@ -205,11 +212,12 @@ bytecodes: [
B(Star), R(12),
B(LdaZero),
B(TestEqualStrict), R(5), U8(15),
- B(JumpIfTrue), U8(121),
+ B(JumpIfTrue), U8(122),
B(LdaUndefined),
B(TestEqualStrict), R(3), U8(16),
- B(JumpIfTrue), U8(115),
- B(LdrNamedProperty), R(3), U8(7), U8(17), R(7),
+ B(JumpIfTrue), U8(116),
+ B(LdaNamedProperty), R(3), U8(7), U8(17),
+ B(Star), R(7),
B(LdaNull),
B(TestEqual), R(7), U8(19),
B(JumpIfFalse), U8(4),
@@ -281,9 +289,9 @@ constant pool: [
FIXED_ARRAY_TYPE,
]
handlers: [
- [11, 116, 122],
- [14, 81, 83],
- [200, 210, 212],
+ [11, 119, 125],
+ [14, 84, 86],
+ [204, 214, 216],
]
---
@@ -295,7 +303,7 @@ snippet: "
"
frame size: 15
parameter count: 1
-bytecode array length: 295
+bytecode array length: 299
bytecodes: [
/* 30 E> */ B(StackCheck),
B(LdaZero),
@@ -305,10 +313,12 @@ bytecodes: [
/* 48 S> */ B(CreateArrayLiteral), U8(0), U8(0), U8(9),
B(Star), R(14),
B(LdaConstant), U8(1),
- /* 48 E> */ B(LdrKeyedProperty), R(14), U8(4), R(13),
+ /* 48 E> */ B(LdaKeyedProperty), R(14), U8(4),
+ B(Star), R(13),
/* 48 E> */ B(CallProperty), R(13), R(14), U8(1), U8(2),
B(Star), R(2),
- /* 45 S> */ B(LdrNamedProperty), R(2), U8(2), U8(8), R(14),
+ /* 45 S> */ B(LdaNamedProperty), R(2), U8(2), U8(8),
+ B(Star), R(14),
/* 45 E> */ B(CallProperty), R(14), R(2), U8(1), U8(6),
B(Star), R(3),
/* 45 E> */ B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(3), U8(1),
@@ -316,8 +326,9 @@ bytecodes: [
B(JumpIfFalse), U8(7),
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(3), U8(1),
B(LdaNamedProperty), R(3), U8(3), U8(10),
- B(JumpIfToBooleanTrue), U8(42),
- B(LdrNamedProperty), R(3), U8(4), U8(12), R(5),
+ B(JumpIfToBooleanTrue), U8(43),
+ B(LdaNamedProperty), R(3), U8(4), U8(12),
+ B(Star), R(5),
B(LdaSmi), U8(2),
B(Star), R(4),
B(Mov), R(5), R(0),
@@ -333,7 +344,7 @@ bytecodes: [
/* 104 S> */ B(Jump), U8(8),
B(LdaZero),
B(Star), R(4),
- B(JumpLoop), U8(-67), U8(0),
+ B(JumpLoop), U8(-69), U8(0),
B(Jump), U8(35),
B(Star), R(13),
B(Ldar), R(closure),
@@ -358,11 +369,12 @@ bytecodes: [
B(Star), R(11),
B(LdaZero),
B(TestEqualStrict), R(4), U8(17),
- B(JumpIfTrue), U8(121),
+ B(JumpIfTrue), U8(122),
B(LdaUndefined),
B(TestEqualStrict), R(2), U8(18),
- B(JumpIfTrue), U8(115),
- B(LdrNamedProperty), R(2), U8(7), U8(19), R(6),
+ B(JumpIfTrue), U8(116),
+ B(LdaNamedProperty), R(2), U8(7), U8(19),
+ B(Star), R(6),
B(LdaNull),
B(TestEqual), R(6), U8(21),
B(JumpIfFalse), U8(4),
@@ -429,9 +441,9 @@ constant pool: [
FIXED_ARRAY_TYPE,
]
handlers: [
- [7, 134, 140],
- [10, 99, 101],
- [217, 227, 229],
+ [7, 137, 143],
+ [10, 102, 104],
+ [221, 231, 233],
]
---
@@ -441,7 +453,7 @@ snippet: "
"
frame size: 14
parameter count: 1
-bytecode array length: 301
+bytecode array length: 306
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(CreateObjectLiteral), U8(0), U8(0), U8(1), R(8),
@@ -453,10 +465,12 @@ bytecodes: [
/* 77 S> */ B(CreateArrayLiteral), U8(1), U8(1), U8(9),
B(Star), R(13),
B(LdaConstant), U8(2),
- /* 77 E> */ B(LdrKeyedProperty), R(13), U8(4), R(12),
+ /* 77 E> */ B(LdaKeyedProperty), R(13), U8(4),
+ B(Star), R(12),
/* 77 E> */ B(CallProperty), R(12), R(13), U8(1), U8(2),
B(Star), R(1),
- /* 74 S> */ B(LdrNamedProperty), R(1), U8(3), U8(8), R(13),
+ /* 74 S> */ B(LdaNamedProperty), R(1), U8(3), U8(8),
+ B(Star), R(13),
/* 74 E> */ B(CallProperty), R(13), R(1), U8(1), U8(6),
B(Star), R(2),
/* 74 E> */ B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(2), U8(1),
@@ -464,15 +478,17 @@ bytecodes: [
B(JumpIfFalse), U8(7),
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(2), U8(1),
B(LdaNamedProperty), R(2), U8(4), U8(10),
- B(JumpIfToBooleanTrue), U8(29),
- /* 67 E> */ B(LdrNamedProperty), R(2), U8(5), U8(12), R(4),
+ B(JumpIfToBooleanTrue), U8(31),
+ /* 67 E> */ B(LdaNamedProperty), R(2), U8(5), U8(12),
+ B(Star), R(4),
B(LdaSmi), U8(2),
B(Star), R(3),
B(Ldar), R(4),
B(StaNamedPropertySloppy), R(0), U8(6), U8(14),
/* 62 E> */ B(StackCheck),
/* 88 S> */ B(Nop),
- /* 96 E> */ B(LdrNamedProperty), R(0), U8(6), U8(16), R(9),
+ /* 96 E> */ B(LdaNamedProperty), R(0), U8(6), U8(16),
+ B(Star), R(9),
B(LdaZero),
B(Star), R(8),
B(Jump), U8(49),
@@ -500,11 +516,12 @@ bytecodes: [
B(Star), R(10),
B(LdaZero),
B(TestEqualStrict), R(3), U8(19),
- B(JumpIfTrue), U8(121),
+ B(JumpIfTrue), U8(122),
B(LdaUndefined),
B(TestEqualStrict), R(1), U8(20),
- B(JumpIfTrue), U8(115),
- B(LdrNamedProperty), R(1), U8(9), U8(21), R(5),
+ B(JumpIfTrue), U8(116),
+ B(LdaNamedProperty), R(1), U8(9), U8(21),
+ B(Star), R(5),
B(LdaNull),
B(TestEqual), R(5), U8(23),
B(JumpIfFalse), U8(4),
@@ -578,8 +595,8 @@ constant pool: [
FIXED_ARRAY_TYPE,
]
handlers: [
- [15, 129, 135],
- [18, 94, 96],
- [213, 223, 225],
+ [15, 133, 139],
+ [18, 98, 100],
+ [218, 228, 230],
]
« no previous file with comments | « test/cctest/interpreter/bytecode_expectations/ForIn.golden ('k') | test/cctest/interpreter/bytecode_expectations/Generators.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698