Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1998)

Unified Diff: test/cctest/interpreter/bytecode_expectations/Generators.golden

Issue 2485383002: [Interpreter] Remove Ldr[Named/Keyed]Property bytecodes and use Star Lookahead instead. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/bytecode_expectations/Generators.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/Generators.golden b/test/cctest/interpreter/bytecode_expectations/Generators.golden
index f6621dbabf3b166c48e4535a0db7cf28b142edb6..38b877506f2baaa37a94b3d52fdbc663fbf156e8 100644
--- a/test/cctest/interpreter/bytecode_expectations/Generators.golden
+++ b/test/cctest/interpreter/bytecode_expectations/Generators.golden
@@ -266,7 +266,7 @@ snippet: "
"
frame size: 18
parameter count: 1
-bytecode array length: 773
+bytecode array length: 775
bytecodes: [
B(Ldar), R(new_target),
B(JumpIfUndefined), U8(28),
@@ -320,7 +320,7 @@ bytecodes: [
B(Star), R(6),
B(LdaZero),
B(Star), R(5),
- B(JumpConstant), U8(19),
+ B(JumpConstant), U8(17),
B(Ldar), R(10),
/* 11 E> */ B(Throw),
B(Ldar), R(closure),
@@ -335,7 +335,8 @@ bytecodes: [
/* 30 S> */ B(CreateArrayLiteral), U8(1), U8(0), U8(9),
B(Star), R(13),
B(LdaConstant), U8(2),
- /* 30 E> */ B(LdrKeyedProperty), R(13), U8(4), R(12),
+ /* 30 E> */ B(LdaKeyedProperty), R(13), U8(4),
+ B(Star), R(12),
/* 30 E> */ B(CallProperty), R(12), R(13), U8(1), U8(2),
/* 30 E> */ B(StaContextSlot), R(1), U8(7), U8(0),
B(LdaSmi), U8(-2),
@@ -348,7 +349,8 @@ bytecodes: [
B(Star), R(12),
B(CallRuntime), U16(Runtime::kAbort), R(12), U8(1),
/* 27 S> */ B(LdrContextSlot), R(1), U8(7), U8(0), R(14),
- B(LdrNamedProperty), R(14), U8(4), U8(8), R(13),
+ B(LdaNamedProperty), R(14), U8(4), U8(8),
+ B(Star), R(13),
/* 27 E> */ B(CallProperty), R(13), R(14), U8(1), U8(6),
/* 27 E> */ B(StaContextSlot), R(1), U8(8), U8(0),
B(Star), R(12),
@@ -359,7 +361,7 @@ bytecodes: [
B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(12), U8(1),
B(LdrContextSlot), R(1), U8(8), U8(0), R(12),
B(LdaNamedProperty), R(12), U8(5), U8(10),
- B(JumpIfToBooleanTrueConstant), U8(9),
+ B(JumpIfToBooleanTrueConstant), U8(3),
B(LdrContextSlot), R(1), U8(8), U8(0), R(12),
B(LdaNamedProperty), R(12), U8(6), U8(12),
B(StaContextSlot), R(1), U8(10), U8(0),
@@ -417,11 +419,11 @@ bytecodes: [
B(PopContext), R(2),
B(LdaZero),
B(StaContextSlot), R(1), U8(9), U8(0),
- B(Wide), B(JumpLoop), U16(-214), U16(0),
+ B(Wide), B(JumpLoop), U16(-215), U16(0),
B(Jump), U8(42),
B(Star), R(12),
B(Ldar), R(closure),
- B(CreateCatchContext), R(12), U8(10), U8(11),
+ B(CreateCatchContext), R(12), U8(9), U8(10),
B(Star), R(11),
B(PushContext), R(2),
B(LdrContextSlot), R(0), U8(9), U8(0), R(12),
@@ -444,19 +446,19 @@ bytecodes: [
B(LdrContextSlot), R(1), U8(9), U8(0), R(11),
B(LdaZero),
B(TestEqualStrict), R(11), U8(15),
- B(JumpIfTrueConstant), U8(17),
+ B(JumpIfTrueConstant), U8(15),
B(LdrContextSlot), R(1), U8(7), U8(0), R(11),
B(LdaUndefined),
B(TestEqualStrict), R(11), U8(16),
- B(JumpIfTrueConstant), U8(18),
+ B(JumpIfTrueConstant), U8(16),
B(LdrContextSlot), R(1), U8(7), U8(0), R(11),
- B(LdaNamedProperty), R(11), U8(12), U8(17),
+ B(LdaNamedProperty), R(11), U8(11), U8(17),
B(StaContextSlot), R(1), U8(11), U8(0),
B(LdrContextSlot), R(1), U8(11), U8(0), R(11),
B(LdaNull),
B(TestEqual), R(11), U8(19),
B(JumpIfFalse), U8(4),
- B(JumpConstant), U8(16),
+ B(JumpConstant), U8(8),
B(LdrContextSlot), R(1), U8(9), U8(0), R(11),
B(LdaSmi), U8(1),
B(TestEqualStrict), R(11), U8(20),
@@ -464,13 +466,13 @@ bytecodes: [
B(LdaContextSlot), R(1), U8(11), U8(0),
B(TypeOf),
B(Star), R(11),
- B(LdaConstant), U8(13),
+ B(LdaConstant), U8(12),
B(TestEqualStrict), R(11), U8(21),
B(JumpIfFalse), U8(4),
B(Jump), U8(18),
B(Wide), B(LdaSmi), U16(130),
B(Star), R(11),
- B(LdaConstant), U8(14),
+ B(LdaConstant), U8(13),
B(Star), R(12),
B(CallRuntime), U16(Runtime::kNewTypeError), R(11), U8(2),
B(Throw),
@@ -481,7 +483,7 @@ bytecodes: [
B(Jump), U8(23),
B(Star), R(12),
B(Ldar), R(closure),
- B(CreateCatchContext), R(12), U8(10), U8(15),
+ B(CreateCatchContext), R(12), U8(9), U8(14),
B(Star), R(11),
B(CallRuntime), U16(Runtime::kInterpreterClearPendingMessage), R(0), U8(0),
B(Ldar), R(11),
@@ -571,28 +573,26 @@ constant pool: [
FIXED_ARRAY_TYPE,
FIXED_ARRAY_TYPE,
SYMBOL_TYPE,
- Smi [148],
+ Smi [149],
ONE_BYTE_INTERNALIZED_STRING_TYPE ["next"],
ONE_BYTE_INTERNALIZED_STRING_TYPE ["done"],
ONE_BYTE_INTERNALIZED_STRING_TYPE ["value"],
FIXED_ARRAY_TYPE,
- Smi [128],
- Smi [149],
+ Smi [129],
ONE_BYTE_INTERNALIZED_STRING_TYPE [".catch"],
FIXED_ARRAY_TYPE,
ONE_BYTE_INTERNALIZED_STRING_TYPE ["return"],
ONE_BYTE_INTERNALIZED_STRING_TYPE ["function"],
ONE_BYTE_INTERNALIZED_STRING_TYPE [""],
FIXED_ARRAY_TYPE,
- Smi [129],
Smi [166],
Smi [155],
- Smi [579],
+ Smi [581],
]
handlers: [
- [46, 688, 694],
- [143, 428, 434],
- [146, 386, 388],
- [542, 556, 558],
+ [46, 690, 696],
+ [143, 430, 436],
+ [146, 388, 390],
+ [544, 558, 560],
]

Powered by Google App Engine
This is Rietveld 408576698