content/browser/appcache/appcache_request_handler_unittest.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_request_handler_unittest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/appcache/appcache_request_handler_unittest.cc

diff --git a/content/browser/appcache/appcache_request_handler_unittest.cc b/content/browser/appcache/appcache_request_handler_unittest.cc

index f8465303a5a12e0cbf07d263266f15b6be3a7130..8367bc8b1f3bea727ee64ec62fc227826b59dd14 100644

--- a/content/browser/appcache/appcache_request_handler_unittest.cc

+++ b/content/browser/appcache/appcache_request_handler_unittest.cc

@@ -1002,7 +1002,7 @@ class AppCacheRequestHandlerTest : public testing::Test {

EXPECT_TRUE(handler_->found_manifest_url_.is_empty());

EXPECT_TRUE(host_->preferred_manifest_url().is_empty());

EXPECT_TRUE(host_->main_resource_blocked_);

- EXPECT_TRUE(host_->blocked_manifest_url_ == GURL("http://blah/manifest/"));

+ EXPECT_EQ(host_->blocked_manifest_url_, "http://blah/manifest/");

TestFinished();

}