Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: components/security_state/security_state_model_unittest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)
Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_state/security_state_model_unittest.cc
diff --git a/components/security_state/security_state_model_unittest.cc b/components/security_state/security_state_model_unittest.cc
index 7776a0c5ba5e492df8a36efef7d189ad3a2db7c9..96f257b7fb918e01beebec99a52c70a04af671de 100644
--- a/components/security_state/security_state_model_unittest.cc
+++ b/components/security_state/security_state_model_unittest.cc
@@ -22,8 +22,8 @@ namespace security_state {
namespace {
-const char kHttpsUrl[] = "https://foo.test";
-const char kHttpUrl[] = "http://foo.test";
+const char kHttpsUrl[] = "https://foo.test/";
+const char kHttpUrl[] = "http://foo.test/";
class TestSecurityStateModelClient : public SecurityStateModelClient {
public:
@@ -91,7 +91,7 @@ class TestSecurityStateModelClient : public SecurityStateModelClient {
bool UsedPolicyInstalledCertificate() override { return false; }
bool IsOriginSecure(const GURL& url) override {
- return url_ == GURL(kHttpsUrl);
+ return url_ == kHttpsUrl;
}
private:
« no previous file with comments | « components/ntp_snippets/remote/ntp_snippets_fetcher.cc ('k') | content/browser/appcache/appcache_request_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698