Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: content/browser/appcache/appcache_request_handler_unittest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)
Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/appcache/appcache_request_handler.h" 5 #include "content/browser/appcache/appcache_request_handler.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <stack> 9 #include <stack>
10 #include <string> 10 #include <string>
(...skipping 984 matching lines...) Expand 10 before | Expand all | Expand 10 after
995 995
996 void Verify_MainResource_Blocked() { 996 void Verify_MainResource_Blocked() {
997 EXPECT_FALSE(job_->is_waiting()); 997 EXPECT_FALSE(job_->is_waiting());
998 EXPECT_FALSE(job_->is_delivering_appcache_response()); 998 EXPECT_FALSE(job_->is_delivering_appcache_response());
999 999
1000 EXPECT_EQ(0, handler_->found_cache_id_); 1000 EXPECT_EQ(0, handler_->found_cache_id_);
1001 EXPECT_EQ(0, handler_->found_group_id_); 1001 EXPECT_EQ(0, handler_->found_group_id_);
1002 EXPECT_TRUE(handler_->found_manifest_url_.is_empty()); 1002 EXPECT_TRUE(handler_->found_manifest_url_.is_empty());
1003 EXPECT_TRUE(host_->preferred_manifest_url().is_empty()); 1003 EXPECT_TRUE(host_->preferred_manifest_url().is_empty());
1004 EXPECT_TRUE(host_->main_resource_blocked_); 1004 EXPECT_TRUE(host_->main_resource_blocked_);
1005 EXPECT_TRUE(host_->blocked_manifest_url_ == GURL("http://blah/manifest/")); 1005 EXPECT_EQ(host_->blocked_manifest_url_, "http://blah/manifest/");
1006 1006
1007 TestFinished(); 1007 TestFinished();
1008 } 1008 }
1009 1009
1010 // Test case helpers -------------------------------------------------- 1010 // Test case helpers --------------------------------------------------
1011 1011
1012 AppCache* MakeNewCache() { 1012 AppCache* MakeNewCache() {
1013 AppCache* cache = new AppCache( 1013 AppCache* cache = new AppCache(
1014 mock_storage(), mock_storage()->NewCacheId()); 1014 mock_storage(), mock_storage()->NewCacheId());
1015 cache->set_complete(true); 1015 cache->set_complete(true);
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
1123 1123
1124 TEST_F(AppCacheRequestHandlerTest, WorkerRequest) { 1124 TEST_F(AppCacheRequestHandlerTest, WorkerRequest) {
1125 RunTestOnIOThread(&AppCacheRequestHandlerTest::WorkerRequest); 1125 RunTestOnIOThread(&AppCacheRequestHandlerTest::WorkerRequest);
1126 } 1126 }
1127 1127
1128 TEST_F(AppCacheRequestHandlerTest, MainResource_Blocked) { 1128 TEST_F(AppCacheRequestHandlerTest, MainResource_Blocked) {
1129 RunTestOnIOThread(&AppCacheRequestHandlerTest::MainResource_Blocked); 1129 RunTestOnIOThread(&AppCacheRequestHandlerTest::MainResource_Blocked);
1130 } 1130 }
1131 1131
1132 } // namespace content 1132 } // namespace content
OLDNEW
« no previous file with comments | « components/security_state/security_state_model_unittest.cc ('k') | content/browser/fileapi/obfuscated_file_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698