Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: components/history/core/test/fake_web_history_service.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)
Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/test/fake_web_history_service.cc
diff --git a/components/history/core/test/fake_web_history_service.cc b/components/history/core/test/fake_web_history_service.cc
index 4f8970534e8f71c7e2cf5e8070161bab6b0427bb..140c209728ac72e7bad80e360435450276d5a6a1 100644
--- a/components/history/core/test/fake_web_history_service.cc
+++ b/components/history/core/test/fake_web_history_service.cc
@@ -106,7 +106,7 @@ const std::string& FakeRequest::GetResponseBody() {
remove_query.ClearQuery();
GURL base_url = url_.ReplaceComponents(remove_query);
- if (base_url == GURL(kLookupUrl) && client == kChromeClient) {
+ if (base_url == kLookupUrl && client == kChromeClient) {
// History query.
int count = service_->GetNumberOfVisitsBetween(begin_, end_);
if (max_count_ && max_count_ < count)
@@ -117,11 +117,11 @@ const std::string& FakeRequest::GetResponseBody() {
response_body_ += i ? ", {}" : "{}";
response_body_ += "] }";
- } else if (base_url == GURL(kDeleteUrl) && client == kChromeClient) {
+ } else if (base_url == kDeleteUrl && client == kChromeClient) {
// Deletion query.
response_body_ = "{ \"just needs to be\" : \"a valid JSON.\" }";
- } else if (base_url == GURL(kLookupUrl) && client == kWebAndAppClient) {
+ } else if (base_url == kLookupUrl && client == kWebAndAppClient) {
// Web and app activity query.
response_body_ = base::StringPrintf(
"{ \"history_recording_enabled\": %s }",

Powered by Google App Engine
This is Rietveld 408576698