components/history/core/browser/history_querying_unittest.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_querying_unittest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/history/core/browser/history_querying_unittest.cc

diff --git a/components/history/core/browser/history_querying_unittest.cc b/components/history/core/browser/history_querying_unittest.cc

index 2e8fbb3c431f08f249b8ec16224805d560bb51b1..da3a53633e42bf0feb8bf6df63ea13129cb577bd 100644

--- a/components/history/core/browser/history_querying_unittest.cc

+++ b/components/history/core/browser/history_querying_unittest.cc

@@ -65,7 +65,7 @@ bool NthResultIs(const QueryResults& results,

return false;

// Now check the URL & title.

- return result.url() == GURL(test_entries[test_entry_index].url) &&

+ return result.url() == test_entries[test_entry_index].url &&

result.title() ==

base::UTF8ToUTF16(test_entries[test_entry_index].title);

}