components/navigation_interception/intercept_navigation_throttle_unittest.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_interception/intercept_navigation_throttle_unittest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/history/core/test/fake_web_history_service.cc ('k') | components/ntp_snippets/remote/ntp_snippets_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_interception/intercept_navigation_throttle_unittest.cc

diff --git a/components/navigation_interception/intercept_navigation_throttle_unittest.cc b/components/navigation_interception/intercept_navigation_throttle_unittest.cc

index a32c2fc4429cb5c78dadb97ce5487217c8e5ba35..a6d27c4945d517894e1d68dc88e5570dc530345c 100644

--- a/components/navigation_interception/intercept_navigation_throttle_unittest.cc

+++ b/components/navigation_interception/intercept_navigation_throttle_unittest.cc

@@ -37,7 +37,7 @@ const char kTestUrl[] = "http://www.test.com/";

// that results in very ugly syntax, which is why these custom matchers are

// used instead.

MATCHER(NavigationParamsUrlIsTest, "") {

- return arg.url() == GURL(kTestUrl);

+ return arg.url() == kTestUrl;

}

} // namespace

« no previous file with comments | « components/history/core/test/fake_web_history_service.cc ('k') | components/ntp_snippets/remote/ntp_snippets_fetcher.cc » ('j') | no next file with comments »