components/error_page/renderer/net_error_helper_core.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/error_page/renderer/net_error_helper_core.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/error_page/renderer/net_error_helper_core.cc

diff --git a/components/error_page/renderer/net_error_helper_core.cc b/components/error_page/renderer/net_error_helper_core.cc

index 904e669b5b4b38d60722ae8a1161e8f0eabc8fed..d2b0b69698352304775dddd0525b90410c65ade3 100644

--- a/components/error_page/renderer/net_error_helper_core.cc

+++ b/components/error_page/renderer/net_error_helper_core.cc

@@ -620,7 +620,7 @@ void NetErrorHelperCore::OnCommitLoad(FrameType frame_type, const GURL& url) {

const GURL& error_url = error.unreachableURL;

if (url == error_url)

ReportAutoReloadSuccess(error, auto_reload_count_);

- else if (url != GURL(content::kUnreachableWebDataURL))

+ else if (url != content::kUnreachableWebDataURL)

ReportAutoReloadFailure(error, auto_reload_count_);

}