Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: net/url_request/url_request.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)
Patch Set: Fix broken tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 368b91ae3eff103afdb77ae5bb48c5e20bc9eeb9..be5816f405002435ce5f180aa9354ec85a67dec5 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -642,8 +642,8 @@ void URLRequest::StartJob(URLRequestJob* job) {
response_info_.was_cached = false;
- if (GURL(referrer_) != URLRequestJob::ComputeReferrerForRedirect(
- referrer_policy_, referrer_, url())) {
+ if (URLRequestJob::ComputeReferrerForRedirect(referrer_policy_, referrer_,
+ url()) != referrer_) {
esprehn 2016/11/09 21:09:25 ditto, why do we not need to canonicalize referrer
cfredric 2016/11/09 22:12:46 I had thought it was already canonicalized here. C
if (!network_delegate_ ||
!network_delegate_->CancelURLRequestWithPolicyViolatingReferrerHeader(
*this, url(), GURL(referrer_))) {

Powered by Google App Engine
This is Rietveld 408576698