Remove unnecessary calls to GURL()

net/url_request/url_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 624 matching lines @@
   job_->SetPriority(priority_);
 
   if (upload_data_stream_.get())
     job_->SetUpload(upload_data_stream_.get());
 
   is_pending_ = true;
   is_redirecting_ = false;
 
   response_info_.was_cached = false;
 
-  if (GURL(referrer_) != URLRequestJob::ComputeReferrerForRedirect(
-                             referrer_policy_, referrer_, url())) {
+  if (URLRequestJob::ComputeReferrerForRedirect(referrer_policy_, referrer_,
+                                                url()) != referrer_) {

[esprehn, 2016/11/09 21:09:25]

ditto, why do we not need to canonicalize referrer_?

[cfredric, 2016/11/09 22:12:46]

I had thought it was already canonicalized here. Changed back.

Is it worth saving the canonicalized value so we can reuse it in the next if
condition? Or is that memory we don't want to use?

     if (!network_delegate_ ||
         !network_delegate_->CancelURLRequestWithPolicyViolatingReferrerHeader(
             *this, url(), GURL(referrer_))) {
       referrer_.clear();
     } else {
       // We need to clear the referrer anyway to avoid an infinite recursion
       // when starting the error job.
       referrer_.clear();
       std::string source("delegate");
       net_log_.AddEvent(NetLogEventType::CANCELLED,
@@ skipping 556 matching lines @@
     out->clear();
 }
 
 void URLRequest::set_status(URLRequestStatus status) {
   DCHECK(status_.is_io_pending() || status_.is_success() ||
          (!status.is_success() && !status.is_io_pending()));
   status_ = status;
 }
 
 }  // namespace net