Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/appcache/appcache_request_handler_unittest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)
Patch Set: Fix broken tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/net/predictor_unittest.cc ('K') | « components/security_state/security_state_model_unittest.cc ('k') | content/browser/fileapi/obfuscated_file_util_unittest.cc » ('j') | net/url_request/url_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_request_handler_unittest.cc
diff --git a/content/browser/appcache/appcache_request_handler_unittest.cc b/content/browser/appcache/appcache_request_handler_unittest.cc
index f8465303a5a12e0cbf07d263266f15b6be3a7130..d8b9d50e292f34ba7f056ef1c32e13c97eeafd74 100644
--- a/content/browser/appcache/appcache_request_handler_unittest.cc
+++ b/content/browser/appcache/appcache_request_handler_unittest.cc
@@ -1002,7 +1002,7 @@ class AppCacheRequestHandlerTest : public testing::Test {
EXPECT_TRUE(handler_->found_manifest_url_.is_empty());
EXPECT_TRUE(host_->preferred_manifest_url().is_empty());
EXPECT_TRUE(host_->main_resource_blocked_);
- EXPECT_TRUE(host_->blocked_manifest_url_ == GURL("http://blah/manifest/"));
+ EXPECT_TRUE(host_->blocked_manifest_url_ == "http://blah/manifest/");
Charlie Harrison 2016/11/09 21:12:58 Use EXPECT_EQ instead of EXPECT_TRUE.
cfredric 2016/11/09 22:12:46 Done.
TestFinished();
}
« chrome/browser/net/predictor_unittest.cc ('K') | « components/security_state/security_state_model_unittest.cc ('k') | content/browser/fileapi/obfuscated_file_util_unittest.cc » ('j') | net/url_request/url_request.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698